From: Ivy Lopez <skunkolee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Ivy Lopez <skunkolee@gmail.com>
Subject: [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8
Date: Sat, 15 Aug 2026 13:10:30 -0600 [thread overview]
Message-ID: <20260815191030.24989-1-skunkolee@gmail.com> (raw)
EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE
(254) but is only ever assigned into s8 (signed char) fields used
to store signed TX power calibration offsets. The implicit
truncation to -2 is intentional. BW20/BW40/CCK/OFDM_Diff fields
elsewhere in the same file already sign-extend 4-bit values into
8-bit signed offsets by hand, so -2 is consistent with that
existing pattern but the untyped macro doesn't communicate this,
and triggers -Wconversion at every one of its 8 use sites in
rtl8723b_hal_init.c.
Cast the macro to s8 at its definition so the sign truncation is
explicit and documented in one place instead of relying on implicit
conversion at each call site.
No functional change.
Signed-off-by: Ivy Lopez <skunkolee@gmail.com>
---
drivers/staging/rtl8723bs/include/hal_pg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/hal_pg.h b/drivers/staging/rtl8723bs/include/hal_pg.h
index 7cb9c441fc01..7f1f004ab817 100644
--- a/drivers/staging/rtl8723bs/include/hal_pg.h
+++ b/drivers/staging/rtl8723bs/include/hal_pg.h
@@ -40,7 +40,7 @@
#define EEPROM_RF_BT_SETTING_8723B 0xC3
#define EEPROM_VERSION_8723B 0xC4
#define EEPROM_CustomID_8723B 0xC5
-#define EEPROM_DEFAULT_DIFF 0XFE
+#define EEPROM_DEFAULT_DIFF ((s8)0XFE)
/* RTL8723BS */
#define EEPROM_MAC_ADDR_8723BS 0x11A
--
2.55.0
reply other threads:[~2026-08-15 19:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260815191030.24989-1-skunkolee@gmail.com \
--to=skunkolee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox