From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A57B3F1052 for ; Thu, 27 Aug 2026 19:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787860629; cv=none; b=X3M6SCJBF7inGsrg1L22Sb2BbbDrnOL5X9XD7G5SDKZelGUzD7NXpsw/mPi4bRPzKNRH6ptck6RvI6NJ/UaxQSurO9bDTUn+JA1PVlEDAcF4HZN4tnODUMZ4Rr5dLUEKmMuL2wcS2EEmLVWsKE8aEpaK74CR1aCcsBsbGZZ0WqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787860629; c=relaxed/simple; bh=vDu5qVZi5+B2YTh94nK7d3oZgqw1oQXWOUqDYalHD4Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=TNRgeCNg+kArcfHvb3kk8HYoFqwkYzYJ+26qQUqmO6hzIbbr+0AA5559Wm7YFdwx4RVVNtaXH29zb6CfSXzl0zAhhdjcHIxxFd9ejpHD0iwwdswT1QpUFpp2eV0B1+8iAGPB+MB12cjY07mgkMiMMOmOpkV3xqrfBHeUqYmJ4aM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z4dW04RT; arc=none smtp.client-ip=209.85.216.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z4dW04RT" Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-39647184c73so1400553a91.1 for ; Thu, 27 Aug 2026 12:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787860627; x=1788465427; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QKSwaBw0Qfs+/Q4v+yYjSyUPLlZIbYu5DPza0B2CzMo=; b=Z4dW04RTOUPFGa3payXnNsJ9vAhcP1AcMUxCKCs6nupvF3gaunrbQcaw9ZcW3m1slk jav/k/2esdCJfSjCO67QY6ocZKdjgyZNFW+OVQGc6OEX31QipRLFBMbbY5vvTJvETTUT T8tUL24zxDCIPT6JVYU1NGTPLCDMy9bd0FMi90LqIjk4u7DmRdzTdaBq/QZq65Xn7onD zlXXrQWKA3KxQBLNJfjIOU1/ZogF/SFuusGZZnUWEK4QImmqt+ScLfsR0HnJ4uE9OVXK VaEa8UhIf151mLDgQ42kp5uLePcXYL8Ria+duVHurujUg1X6E0icyfXMTcpkcHTnk/B/ Nk4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787860627; x=1788465427; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QKSwaBw0Qfs+/Q4v+yYjSyUPLlZIbYu5DPza0B2CzMo=; b=UktR8OOkigmMs+v0LQAeXHRnMa9YOjcid/Wp5YWYB2oIxP9uHtjjgFCFz+t/473kLT yoivbmy0wWSk3PgxJjKVwhgf3e4hCZY+tjzzYN5uJqR0Ss87WJKMokSMFHsmN/ipV+CZ Vnm4ug7JhtuBpGdXRkbIa/xbFTN8ymFiWFvjjZKbLxJNl7sUsrZTtbavfGQQ7NM0JXiQ gbk+seV6dxBxhkL4iYS2ddwU0Toxa5R83uldm1cvwZ/7THo4QXLhwwxhj6U9f7wW4FzW 3pyiayBgiUgjKAjd9PLyGg12k3JmCTE8D6+SE3QZC2Z6K7QMOX5bBr/MBYcNM17Egdhq ZKew== X-Forwarded-Encrypted: i=1; AHgh+RrCJFhkXiyIHlSiIqklxDT1trrz4ezHL2GbJvU8ok7gNhq/WKZi3Qc/ayoAdOQ0feaEALbUri2i0O8eMAUS@lists.linux.dev X-Gm-Message-State: AFuF++n3Ff/xUMi8UJUDSmoviZ9NNh4m9HyRkEjYkFPZshYMXt2gtsbi 0WwLEK0BBUuu8K220fyyrP3ASy7p1nF99LW9CUyXiKCAGi6Yy5cwCE3NOa+5hvmpkaprxQ== X-Gm-Gg: AR+sD13K4nUymr684a2Y3zZ/MYrdop1gTMKmCg3YReJ7ForM6aYPMhnuJZOneWWQAH3 2dHXki//OJy/96CWgpWXZWaRlLs5x2eA7sO/vyIVvaPZaeXcpNC0iZL7MPTxPE14lWSpeHdOAJJ qzyTmsHclr+g5lDJJUYFlva0xSXvmiFcTG2mExcLxoIq3Yp4XzxxWT8magi4SFv7So4JhWa3sJt OuDVC9kiO74DttjLk1avIScQ0/kYNywGgiO/DE1gYUgeXraXrnv/w32bEdF0Z1xZCCiGY+40WAd WC4aKaEJyTgFAx0nm8FnMThRwblTAnFASX1WPejsqfRvx+QMu1iNEqqwXWY0y27YxRf2Ke5N3ac 0rRQhP6nINPIJ3Kdv1/iqpQY9RKOmY7sLIotIMsl6X+mUxZSsSbJYYcN5Q5jH6GGB08VaXFpmAg xIaW0U8QTIO1gInXxmuiR8e0rrrj4J1ZsjPQ3mtOFih/AHl2K0bRW6EvMK9CtHVqhg3RoR1SZW X-Received: by 2002:a17:90b:4fd0:b0:38e:9784:dd47 with SMTP id 98e67ed59e1d1-3969ba3c181mr13031508a91.1.1787860627206; Thu, 27 Aug 2026 12:57:07 -0700 (PDT) Received: from Mahmudul.. ([103.139.196.183]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3285a5f96efsm9258581eec.11.2026.08.27.12.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 12:57:06 -0700 (PDT) From: "Md. Mahmudul Hasan Mabud" To: jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org Cc: andy@kernel.org, dlechner@baylibre.com, linux@analog.com, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Md. Mahmudul Hasan Mabud" Subject: [PATCH v5] staging: iio: adc: ad7816: Use modern IIO attribute macros Date: Fri, 28 Aug 2026 01:56:42 +0600 Message-Id: <20260827195642.12831-1-mdmahmudulhasan1511@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the legacy IIO_DEVICE_ATTR() macros with the modern IIO_DEVICE_ATTR_RW() and IIO_DEVICE_ATTR_RO() macros. This includes renaming driver-specific callback functions to standard _show() and _store() formats. Signed-off-by: Md. Mahmudul Hasan Mabud --- v5: - Converted to a standalone single patch (previously part of the v3/v4 series). - Updated commit message and fixed function header line lengths and wrapping based on Andy Shevchenko's feedback on v3. Link: https://lore.kernel.org/linux-iio/act9ovNVsJvWO6Cx@ashevche-desk.local/ v4: - Sent by mistake without updates. v3: - Initial version (as patch 4/4 of the series). drivers/staging/iio/adc/ad7816.c | 64 ++++++++++++-------------------- 1 file changed, 24 insertions(+), 40 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c index 30644d2d7..62bbd7b34 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -116,9 +116,8 @@ static int ad7816_spi_write(struct ad7816_chip_info *chip, u8 data) return ret; } -static ssize_t ad7816_show_mode(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t mode_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -128,10 +127,8 @@ static ssize_t ad7816_show_mode(struct device *dev, return sysfs_emit(buf, "full\n"); } -static ssize_t ad7816_store_mode(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t mode_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t len) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -147,24 +144,19 @@ static ssize_t ad7816_store_mode(struct device *dev, return len; } -static IIO_DEVICE_ATTR(mode, 0644, - ad7816_show_mode, - ad7816_store_mode, - 0); +static IIO_DEVICE_ATTR_RW(mode, 0); -static ssize_t ad7816_show_available_modes(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t available_modes_show(struct device *dev, + struct device_attribute *attr, + char *buf) { return sysfs_emit(buf, "full\npower-save\n"); } -static IIO_DEVICE_ATTR(available_modes, 0444, ad7816_show_available_modes, - NULL, 0); +static IIO_DEVICE_ATTR_RO(available_modes, 0); -static ssize_t ad7816_show_channel(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t channel_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -172,10 +164,8 @@ static ssize_t ad7816_show_channel(struct device *dev, return sysfs_emit(buf, "%d\n", chip->channel_id); } -static ssize_t ad7816_store_channel(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static ssize_t channel_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t len) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -205,14 +195,10 @@ static ssize_t ad7816_store_channel(struct device *dev, return len; } -static IIO_DEVICE_ATTR(channel, 0644, - ad7816_show_channel, - ad7816_store_channel, - 0); +static IIO_DEVICE_ATTR_RW(channel, 0); -static ssize_t ad7816_show_value(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t value_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -236,7 +222,7 @@ static ssize_t ad7816_show_value(struct device *dev, return sysfs_emit(buf, "%u\n", data); } -static IIO_DEVICE_ATTR(value, 0444, ad7816_show_value, NULL, 0); +static IIO_DEVICE_ATTR_RO(value, 0); static struct attribute *ad7816_attributes[] = { &iio_dev_attr_available_modes.dev_attr.attr, @@ -266,9 +252,8 @@ static irqreturn_t ad7816_event_handler(int irq, void *private) return IRQ_HANDLED; } -static ssize_t ad7816_show_oti(struct device *dev, - struct device_attribute *attr, - char *buf) +static ssize_t oti_show(struct device *dev, struct device_attribute *attr, + char *buf) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -286,10 +271,10 @@ static ssize_t ad7816_show_oti(struct device *dev, return sysfs_emit(buf, "%u\n", chip->oti_data[chip->channel_id]); } -static inline ssize_t ad7816_set_oti(struct device *dev, - struct device_attribute *attr, - const char *buf, - size_t len) +static inline ssize_t oti_store(struct device *dev, + struct device_attribute *attr, + const char *buf, + size_t len) { struct iio_dev *indio_dev = dev_to_iio_dev(dev); struct ad7816_chip_info *chip = iio_priv(indio_dev); @@ -327,8 +312,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev, return len; } -static IIO_DEVICE_ATTR(oti, 0644, - ad7816_show_oti, ad7816_set_oti, 0); +static IIO_DEVICE_ATTR_RW(oti, 0); static struct attribute *ad7816_event_attributes[] = { &iio_dev_attr_oti.dev_attr.attr, -- 2.34.1