From: Anshika Jain <anshikajain196872@gmail.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
sashiko-bot@kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
Anshika Jain <anshikajain196872@gmail.com>
Subject: [PATCH] staging: fbtft: fix len<=0 buffer overflow in define_fbtft_write_reg()
Date: Wed, 2 Sep 2026 10:20:26 +0530 [thread overview]
Message-ID: <20260902045026.7442-1-anshikajain196872@gmail.com> (raw)
If len is 0 or negative when a define_fbtft_write_reg()-generated
function is called, len-- underflows to -1, causing the subsequent
while (i--) loop to run approximately 2^31 times and write far past
the end of buf.
This is a latent bug: nothing in the current code prevents two
adjacent negative values in an init_sequence from producing len=0,
and there is no guarantee future or out-of-tree panel definitions
won't do so.
Add an early return for len <= 0, matching the existing guard already
present in the sibling function fbtft_write_reg8_bus9().
Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Link: https://sashiko.dev/#/patchset/20260830161529.14500-1-anshikajain196872@gmail.com?part=1
Signed-off-by: Anshika Jain <anshikajain196872@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index e03aa251c..7d7135571 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -20,6 +20,9 @@ void func(struct fbtft_par *par, int len, ...) \
int offset = 0; \
buffer_type *buf = (buffer_type *)par->buf; \
\
+ if (len <= 0) \
+ return; \
+ \
if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { \
va_start(args, len); \
for (i = 0; i < len; i++) { \
--
2.34.1
next reply other threads:[~2026-09-02 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 4:50 Anshika Jain [this message]
2026-09-02 5:58 ` [PATCH] staging: fbtft: fix len<=0 buffer overflow in define_fbtft_write_reg() Greg Kroah-Hartman
2026-09-02 12:25 ` Nam Cao
[not found] ` <CABj3sPEMo3B9B0ynfLGD=NmMu+0zpZ_Ydf2yyT7NDaT3DDNq=A@mail.gmail.com>
2026-09-03 8:24 ` Nam Cao
2026-09-03 8:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902045026.7442-1-anshikajain196872@gmail.com \
--to=anshikajain196872@gmail.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox