From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EA774A3D56 for ; Sat, 5 Sep 2026 12:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788613051; cv=none; b=kGVTLPwzBaeNf7SWaDntl6BwylMrStODTRkJTRuKlxE6tBDhVqfOYTM4y4sciYXj63j2UgczIQlJu9pna0fZLNwZ8zURNByXEM2CI9ZQejlypqCmt5uotsqcmqDFEVLd4OHUs159vtDyb+Ui6+WLgk5v0AvWr20eIFsWM3vOZA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788613051; c=relaxed/simple; bh=0GbiNyL6PaCeFSnzxifaG0jpg42+buGimYKFRJQqiJM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TCUm6sznyw6IIAOruLHvwS/rcdoT+VX0rk+3UFa2sogoT/hpb86xSmb3knPr4THp0nWeR7kDmi/dSmKfyeuPtYNpA4R3Bd2U3zbzNLWmy1+04OfSLtBgxQ1ZiTnRChr/yLZTz+siU/fIVb0G+MPjKb7sM41RpDUoTOxn5VMJVGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DBwMVWBb; arc=none smtp.client-ip=209.85.221.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DBwMVWBb" Received: by mail-vk1-f169.google.com with SMTP id 71dfb90a1353d-5bf83925ddaso1029145e0c.1 for ; Sat, 05 Sep 2026 05:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788613048; x=1789217848; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iiwxf8iLXv/0xdcKcz3UiNeEjss20ShbniaWoqOFMcg=; b=DBwMVWBbHgwahS62g2VAcHk6+wFrkrib0CNGfjrlR/iLb57jnEqeAuYvW5474Z4bXb k78tWLqL3lxJ2BtP7CmJLKiHltOPlk4GlFJxeH3w0d+pOfqhyQ79113Yb+ntjYhodvaV uDg0S6yRzD0vIENRsNoV2klvSvCn93ZLetBC02vuH1bEgJRt+IFk7ObWSR1cy+s7EiS3 XQADro9alPTq4gxoP5rxa1fXb9+Kh3O0Ji12X6x9IuhGp94L8KErOivNHqMVCcX5RCkx Vwu15avctDEE/1htmMKrPwRFqvDzCPEwvjfsGztsNbUyoxPcXT6Udmg1yMjlnFo2NhMk PTNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788613048; x=1789217848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iiwxf8iLXv/0xdcKcz3UiNeEjss20ShbniaWoqOFMcg=; b=Ob9zTk4bRCgvaU4pItzsR9cSiHVyy83MFYfTvCfjNmR8eQPVLfeLzoj+E11f86FxXn cY2j4z0v3d4NCeVO3CCbcMaomvNgdQ9GOpFpSzEMYrnTyNLJa0AEA/BVG4i50EVrtRL3 6TOKOeNzxXqLg3DdalSaK6Y/UsW2ehoL5EWEORRH6oaqc2sfeToDdSRdM/ws4wxpqgWS p71KxlWjC5y9SeSYcwZt2SsGPfs31zqOCe81Zw1d7BQEv30hcPHzyN/IOCZL39rfxxH+ N4h4f9ayQHpowmLvXxGUfRj7cxyRnw4JbLUd8/UY4mLnhx/LsiiI12gbjFWLsBU/I5JE 3vkw== X-Forwarded-Encrypted: i=1; AKwUvBxEO+DIy4vbXjBYaazPc2WPW7XAUpsblbdSop4AoffHufqiJClVekBZi6DILJg/62sxLUkrewwBGFI3RlM6@lists.linux.dev X-Gm-Message-State: AFuF++mAnF6FcKkai4QlI+yEo+Hjizp9RvocaWK7K56TQyEfXxKNgzqO /2OzI/TquVfQSPtyCxmaXh82cjFv6D84Q7HMb6XMs3iA/5cnm6bvpfyGrqThar19 X-Gm-Gg: AYBFou2yWsGJI929zxC4P4JKBvafYFGCcREs8ahpbvkelYcGKxDtV/DxDqopjdChIQy kdZYeaiJodFQlrmC7CdhM4/LLjpDnTPqCSdbG7gNvaj1YXuJa/blhC80z4VHaLkitWywgSQN9b0 J94u0F9W6UX5InlN4XMmniPLghfqK73ieTXG1fzRHqBFPH3dxfBc1BVBGJ6Al9wWmjUCSzsabzB 3Q2lMGp9vlZs2+dn5r8c0RV28QsJXnnLNcXw48LHdQvPyC4PWUb3oyU/yWIF6nUDOM5Qp8Xqwq5 1Ebk1fgOwbseLyRr6m6wWT0zlI3xELiskU0IauYoy5TIR7qV2UQEaFlPVnn2luE7gFWyLyhBwsH rg7MQGTW3xUvjO/yKk53nwiBpK9734eSCAQg2HDk/qa3Afse2625UDzc3l6Dxfqn2yEqtP7LhaN cOMpB+2acmrXtO7GPqFIR7q7EIPFL9a/nxgAzTb/I7854LRnA06gx01Td3ujZ4cg99BdeqU+Yug 38NMTlo7wSE31J6d2skZcda7sZf6X+zfh/wPw3X2TQ= X-Received: by 2002:a05:6122:1d47:b0:5c4:1f03:a1fe with SMTP id 71dfb90a1353d-5c7ed298c90mr4817731e0c.1.1788613047695; Sat, 05 Sep 2026 05:57:27 -0700 (PDT) Received: from Biostar-A520MT.. ([187.94.13.245]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c7ec1ef7a5sm4349416e0c.5.2026.09.05.05.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2026 05:57:27 -0700 (PDT) From: Breno Rodrigues Alves To: gregkh@linuxfoundation.org Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linux-clk@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org, linux-security-module@vger.kernel.org, Breno Rodrigues Alves Subject: [PATCH v8 3/3] media: dvb-core: extirpate defective and unsafe ULE debug block Date: Sat, 5 Sep 2026 09:57:06 -0300 Message-ID: <20260905125706.6550-3-breno3011alves@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260905125706.6550-1-breno3011alves@gmail.com> References: <20260905125706.6550-1-breno3011alves@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Completely purge the unmaintained DVB_ULE_DEBUG code block from dvb_net.c and its Kconfig definition to eliminate severe lockless race conditions and clean up unused function parameters. Assisted-by: OpenCode AI Signed-off-by: Breno Rodrigues Alves --- drivers/media/dvb-core/Kconfig | 11 --------- drivers/media/dvb-core/dvb_net.c | 40 -------------------------------- 2 files changed, 51 deletions(-) diff --git a/drivers/media/dvb-core/Kconfig b/drivers/media/dvb-core/Kconfig index 8b3f2d53c..c6a97add8 100644 --- a/drivers/media/dvb-core/Kconfig +++ b/drivers/media/dvb-core/Kconfig @@ -67,14 +67,3 @@ config DVB_DEMUX_SECTION_LOSS_LOG If you are unsure about this, say N here. -config DVB_ULE_DEBUG - bool "Enable DVB net ULE packet debug messages" - depends on DVB_CORE - help - Enable extra log messages meant to detect problems while - handling DVB network ULE packet loss inside the Kernel. - - Should not be enabled on normal cases, as logs can - be very verbose. - - If you are unsure about this, say N here. diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c index a2159b2bc..ae0073b94 100644 --- a/drivers/media/dvb-core/dvb_net.c +++ b/drivers/media/dvb-core/dvb_net.c @@ -68,19 +68,6 @@ static inline __u32 iov_crc32( __u32 c, struct kvec *iov, unsigned int cnt ) #define DVB_NET_MULTICAST_MAX 10 -#ifdef DVB_ULE_DEBUG -/* - * The code inside DVB_ULE_DEBUG keeps a history of the - * last 100 TS cells processed. - */ -static unsigned char ule_hist[100*TS_SZ] = { 0 }; -static unsigned char *ule_where = ule_hist, ule_dump; - -static void hexdump(const unsigned char *buf, unsigned short len) -{ - print_hex_dump_debug("", DUMP_PREFIX_OFFSET, 16, 1, buf, len, true); -} -#endif struct dvb_net_priv { int in_use; @@ -320,16 +307,6 @@ static int dvb_net_ule_new_ts_cell(struct dvb_net_ule_handle *h) { /* We are about to process a new TS cell. */ -#ifdef DVB_ULE_DEBUG - if (ule_where >= &ule_hist[100*TS_SZ]) - ule_where = ule_hist; - memcpy(ule_where, h->ts, TS_SZ); - if (ule_dump) { - hexdump(ule_where, TS_SZ); - ule_dump = 0; - } - ule_where += TS_SZ; -#endif /* * Check TS h->error conditions: sync_byte, transport_error_indicator, @@ -659,23 +636,6 @@ static void dvb_net_ule_check_crc(struct dvb_net_ule_handle *h, h->ts_remain > 2 ? *(unsigned short *)h->from_where : 0); - #ifdef DVB_ULE_DEBUG - hexdump(iov[0].iov_base, iov[0].iov_len); - hexdump(iov[1].iov_base, iov[1].iov_len); - hexdump(iov[2].iov_base, iov[2].iov_len); - - if (ule_where == ule_hist) { - hexdump(&ule_hist[98*TS_SZ], TS_SZ); - hexdump(&ule_hist[99*TS_SZ], TS_SZ); - } else if (ule_where == &ule_hist[TS_SZ]) { - hexdump(&ule_hist[99*TS_SZ], TS_SZ); - hexdump(ule_hist, TS_SZ); - } else { - hexdump(ule_where - TS_SZ - TS_SZ, TS_SZ); - hexdump(ule_where - TS_SZ, TS_SZ); - } - ule_dump = 1; - #endif h->dev->stats.rx_errors++; h->dev->stats.rx_crc_errors++; -- 2.43.0