Linux kernel staging patches
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hank Yang <s950343@gmail.com>
Cc: linux-staging@lists.linux.dev, b9788213@gmail.com, guojy.bj@gmail.com
Subject: Re: staging: rtl8723bs: possible dead code in GetDeltaSwingTable_8723B (5GHz fallback path)
Date: Sat, 5 Sep 2026 19:14:12 +0200	[thread overview]
Message-ID: <2026090527-outdoors-press-9602@gregkh> (raw)
In-Reply-To: <20260905132248.2951-1-s950343@gmail.com>

On Sat, Sep 05, 2026 at 09:22:41PM +0800, Hank Yang wrote:
> Hi Greg and staging maintainers,
> 
> I believe I've found dead code in
> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c — a fallback branch
> in GetDeltaSwingTable_8723B() that can never execute, since it uses
> calibration tables from a different chip (8188E). If my reasoning
> below holds, I'd like to remove this else branch, but I wanted to
> check with you first before sending a patch. Details below:

There are loads of "dead code" in staging drivers, that's why they are
in staging :)

If you think it should be removed, then make a patch to remove it and
submit it and we will be glad to review it like any other submission.

thanks,

greg k-h

      reply	other threads:[~2026-09-05 17:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 13:22 staging: rtl8723bs: possible dead code in GetDeltaSwingTable_8723B (5GHz fallback path) Hank Yang
2026-09-05 17:14 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026090527-outdoors-press-9602@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=b9788213@gmail.com \
    --cc=guojy.bj@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    --cc=s950343@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox