Linux kernel staging patches
 help / color / mirror / Atom feed
From: b9788213@gmail.com
To: s950343@gmail.com
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	b9788213@gmail.com, guojy.bj@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: remove dead 5GHz fallback in GetDeltaSwingTable_8723B
Date: Sun,  6 Sep 2026 14:29:50 +0300	[thread overview]
Message-ID: <20260906112956.101264-1-b9788213@gmail.com> (raw)
In-Reply-To: <20260906042043.1850-1-s950343@gmail.com>

> This branch is unreachable. `channel` comes from `CurrentChannel`,
> which is only updated in rtl8723b_phycfg.c after passing
> HAL_IsLegalChannel(), which enforces a range of 1 to 14

	if ((!Adapter->driver_stopped) && (!Adapter->bSurpriseRemoved)) {
		phy_SwChnlAndSetBwMode8723B(Adapter);
	} else {
		if (pHalData->bSwChnl) {
			pHalData->CurrentChannel = tmpChannel;
			pHalData->CurrentCenterFrequencyIndex1 = tmpChannel;
		}

		if (pHalData->bSetChnlBW) {
			pHalData->CurrentChannelBW = tmpBW;
			pHalData->nCur40MhzPrimeSC = tmpnCur40MhzPrimeSC;
			pHalData->nCur80MhzPrimeSC = tmpnCur80MhzPrimeSC;
			pHalData->CurrentCenterFrequencyIndex1 = tmpCenterFrequencyIndex1;
		}
	}

In else branch pHalData->bSwChnl is still true.
It is possible to write an invalid value to pHalData->CurrentChannel with PHY_HandleSwChnlAndSetBW8723B().

Thanks,
Bera

  reply	other threads:[~2026-09-06 11:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06  4:20 [PATCH] staging: rtl8723bs: remove dead 5GHz fallback in GetDeltaSwingTable_8723B Hank Yang
2026-09-06 11:29 ` b9788213 [this message]
2026-09-06 12:46   ` Hank Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260906112956.101264-1-b9788213@gmail.com \
    --to=b9788213@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guojy.bj@gmail.com \
    --cc=linux-staging@lists.linux.dev \
    --cc=s950343@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox