From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28D4360EC3 for ; Thu, 24 Sep 2026 15:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790262984; cv=none; b=qtrdxlPTd0tFEOljsD9uUCyhvKuEsOTVl04M0ox0TA7ffE4cjvQ+4vJbX0Yg/nm0LBF+WzTacsNKbt1Pulv/EFQXbnGeKNJWUkb/FkqOpFRoe6u6yAwKpOjGsPOUPlKWk+IJwdXEh0AvTrmvZKXtzds5O0l2QO1XbRjBypTaLUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790262984; c=relaxed/simple; bh=sSDsbyo3U7X/rk8CC4bA7N4TkoHw6sZDVq3p830+v+g=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qd2ijxIMpqsQKxmCSAsTRcGOXanxVCZrYnH+LxtrcgDvN0i+O2nR13b18SkZRl3UnvUzMI1loQvtzJTmCiB+b4xg2k0wNB9HscIaHiqT2/35JWhDjtDcNjCP83dazvCqj/rkMMKAnQtgNnvymoLca8HQGcx8PyO+oYCykHUWpIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AwuLdnW+; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AwuLdnW+" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-39b5b07ec78so1234339a91.3 for ; Thu, 24 Sep 2026 08:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790262982; x=1790867782; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=inAXO/fQBA9wM1TfaIutqtVZU1aIPtXVqWMiUQgtv7w=; b=AwuLdnW+UeIf5O+nJRYKx1J5eIkrlPYjGzVyTmNAWxR8p2f5p4CDhwJrbeP+3lnG0u XM9RWHpQJXM98fTDr5LWf79JpA4zGdp3W11Defr01eH01G7bL8Pbyt93BEEDeg2/L4Lk ZL4aIYwCScBbNuiM3atCdpJPonq1xaTG8dSrUT6SrLVFE0lRwuCe4j749y6JkegJLy7s BxI4yswfDofpepbd33mlYvqYfBEZJgXwczDURh5uAxB9sscwUFewEX8tVkOYG8h45tqT kMnIpYot1Bhsk1u1MFKy0crcY1R6PlEVb2213N0l7Mzm2xb+Kv1UDvGWwmz73t0BLyvJ IH0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790262982; x=1790867782; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=inAXO/fQBA9wM1TfaIutqtVZU1aIPtXVqWMiUQgtv7w=; b=vQcD6TkRKmogMSl5FRA/wZ2zz7IdE6/rhN7zvsWf1HRmIPVYpq5RAKvpGWOR3ADEcW HE0JeuSAuRFUm6UaBr1GVQs3bVy1a1o0nGb/An8Rf0ESjAIUEZCKajpqFUvSME370Jb0 Extc2E6JS3ngXKQl2bxU0mCz3kOeP0ldNRjFrKpqshAciihysR6lty9oc7KgaBKxOzi5 qJ32RVlJq7WR6vkQzaISIvRkdZ/omQyG14d3Velb+MY5tYm0jQQh7vPY8iXpfGZKTPfn U+H3XTXL8KPK4N0wQ8lNVyyMRQlus96mqETnp3g8mRgPD3iGsILEgCQs7uoKZV1G7P1l tqYA== X-Forwarded-Encrypted: i=1; AKwUvBw2D0SZjaVTnkuqvUt5nTuJBhgESjGJHqUsDWS5E6a/sLz4V0RX+7iSIz7K9HUITb4A7F0aPs14rBi9eYbv@lists.linux.dev X-Gm-Message-State: AFuF++kzMJL92nj5rBH05fJt54iQyXVJkydCDxbNrUbH0alrymPcG4Ar dWMVlYpAg9utUPfsOVH5jgAsoIdAcavYTyGY2ipgCQ0MTer9ou3sk45E X-Gm-Gg: AYBFou3NCnkqXcfZHcPai6QanbueD1GoYjXmX/ZwjIoEb5nZNQiev+Bj8ONYNuNQtzY 9MKzm2CvEr7mQRfQVsCofUcEIS8FA5i7BKqDUfnvkNk9TAmOgbg7Rx+T0YzgiBs8uNwLYFSBa9a pWU48Hc3fBye28cSz8rVgvOdeMUM8iTVKmKAQBm6GamNlvmAqoiNeto4UD5xC6iir8l/4QraNpx zOaMvuJl6DfgRXHOtueXeZnIMt98+jv+rdogXBqcNThRuksiivJ4ngEdpspbunWNCW5VILHwMuk Fb/0yUi+7eTu7UGSGiP760SXV3wTm25xnHhVpqNSaBN5hFaKH3yCCpJ0nSrGbwZm8wG+KF1tcU5 8FXeduGGlOwSdsyKnPT+DMoogNdFYc+K6+c5CnkiHoYptZNuJOmdSUERO84vkfVXla/FAgvUH5x 8ISlLeN8aGk0ogiqUDZGsRjXEVkVoN9UahsSXduqg/dOznz8L10qse7+o/BTOscGxhwaSOdGsvD Oy2xf1l5y/dFrF4eITdAdHSnw== X-Received: by 2002:a17:90b:4c0b:b0:39e:34d6:7eb5 with SMTP id 98e67ed59e1d1-3a098570e66mr2653799a91.9.1790262981988; Thu, 24 Sep 2026 08:16:21 -0700 (PDT) Received: from localhost.localdomain ([223.167.219.30]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc75f3d6954sm2844459a12.16.2026.09.24.08.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 08:16:21 -0700 (PDT) From: "Eric LI (Honggang)" To: Greg Kroah-Hartman Cc: Hungyu Lin , Andrei Khomenkov , Khushal Chitturi , Ethan Tidmore , Oskar Ray-Frayssinet , SeungJu Cheon , Dalvin-Ehinoma Noah Aiguobas , Jennifer Guo , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: refactor xmit_xmitframe Date: Thu, 24 Sep 2026 23:16:06 +0800 Message-Id: <20260924151606.333467-1-eric.lee0305@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refactor the function xmit_xmitframe in rtl8723bs_xmit.c to reduce the leading tabs Signed-off-by: Eric LI (Honggang) --- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 43 ++++++++++--------- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index 7f55448d544e..46895b05538d 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -231,29 +231,30 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv /* check xmit_buf size enough or not */ txlen = txdesc_size + rtw_wlan_pkt_size(pxmitframe); - if (!pxmitbuf || - ((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) || - (k >= (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1)) + if (pxmitbuf && + (((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) || + (k >= (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1))) ) { - if (pxmitbuf) { - /* pxmitbuf->priv_data will be NULL, and will crash here */ - if (pxmitbuf->len > 0 && - pxmitbuf->priv_data) { - struct xmit_frame *pframe; - - pframe = (struct xmit_frame *)pxmitbuf->priv_data; - pframe->agg_num = k; - pxmitbuf->agg_num = k; - rtl8723b_update_txdesc(pframe, pframe->buf_addr); - rtw_free_xmitframe(pxmitpriv, pframe); - pxmitbuf->priv_data = NULL; - enqueue_pending_xmitbuf(pxmitpriv, pxmitbuf); - /* can not yield under lock */ - /* yield(); */ - } else - rtw_free_xmitbuf(pxmitpriv, pxmitbuf); - } + if (pxmitbuf->len > 0 && + pxmitbuf->priv_data) { + struct xmit_frame *pframe; + + pframe = (struct xmit_frame *)pxmitbuf->priv_data; + pframe->agg_num = k; + pxmitbuf->agg_num = k; + rtl8723b_update_txdesc(pframe, pframe->buf_addr); + rtw_free_xmitframe(pxmitpriv, pframe); + pxmitbuf->priv_data = NULL; + enqueue_pending_xmitbuf(pxmitpriv, pxmitbuf); + /* can not yield under lock */ + /* yield(); */ + } else + rtw_free_xmitbuf(pxmitpriv, pxmitbuf); + + pxmitbuf = NULL; + } + if (!pxmitbuf) { pxmitbuf = rtw_alloc_xmitbuf(pxmitpriv); if (!pxmitbuf) { err = -2; -- 2.34.1