From: John Singleton <johnsingleton@google.com>
To: andy.shevchenko@gmail.com
Cc: andy@kernel.org, gregkh@linuxfoundation.org, hansg@kernel.org,
johnsingleton@google.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
mchehab@kernel.org, sakari.ailus@linux.intel.com
Subject: [PATCH 3/3] staging: media: atomisp: Fix parameter indentation and block comments
Date: Wed, 14 Oct 2026 14:50:37 +0000 [thread overview]
Message-ID: <20261014145045.2369689-1-johnsingleton@google.com> (raw)
In-Reply-To: <CAHp75VdjeG2kNzfRRAmHZp=++gOz48ifnKMCu0oPK=nZBewHPA@mail.gmail.com>
On Wed, Oct 14, 2026 at 9:20 AM John Singleton <johnsingleton@google.com> wrote:
>
> Thank you, Andy. Just to confirm from my examination, I think the key issues are:
> 1) There should be separate patches for the comment-cleanup and the function-header cleanup and
> 2) The preference is to do this for all files in a directory, rather than a subset.
>
> Is that a fair summary of the concerns?
>
> On Mon, Oct 12, 2026 at 2:05 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>
>> On Mon, Oct 12, 2026 at 7:13 PM John Singleton <johnsingleton@google.com> wrote:
>> >
>> > Replace leading spaces with tabs in function parameter lists and
>> > format multi-line comments according to kernel coding style.
>>
>> Please, read the mail archive to understand why this patch is no-go.
Thank you, Andy. Just to confirm from my examination, I think the key issues are:
1) There should be separate patches for the comment-cleanup and the function-header cleanup and
2) The preference is to do this for all files in a directory, rather than a subset.
Is that a fair summary of the concerns?
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
next prev parent reply other threads:[~2026-10-14 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 16:13 [PATCH 1/3] staging: media: atomisp: Make pmic_name array const John Singleton
2026-10-12 16:13 ` [PATCH 2/3] staging: media: atomisp: Remove extraneous dev_dbg John Singleton
2026-10-12 19:05 ` Andy Shevchenko
2026-10-12 16:13 ` [PATCH 3/3] staging: media: atomisp: Fix parameter indentation and block comments John Singleton
2026-10-12 19:04 ` Andy Shevchenko
2026-10-14 14:50 ` John Singleton [this message]
2026-10-12 19:07 ` [PATCH 1/3] staging: media: atomisp: Make pmic_name array const Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014145045.2369689-1-johnsingleton@google.com \
--to=johnsingleton@google.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox