From: Temitope obabi <obabitemitope765@gmail.com>
To: outreachy@lists.linux.dev
Cc: Temitope obabi <obabitemitope765@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: sm750fb: Remove redundant zero assignments
Date: Sun, 18 Oct 2026 17:15:18 +0300 [thread overview]
Message-ID: <20261018141519.10165-1-obabitemitope765@gmail.com> (raw)
The sm750_dev structure is allocated with devm_kzalloc() before
sm750fb_setup() is called, so the init_parm fields are already zero.
Remove the four assignments that set them to zero again.
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8b93bfeb217b..21744a5a63fb 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -833,10 +833,6 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
swap = 0;
- sm750_dev->init_parm.chip_clock = 0;
- sm750_dev->init_parm.mem_clock = 0;
- sm750_dev->init_parm.master_clock = 0;
- sm750_dev->init_parm.power_mode = 0;
sm750_dev->init_parm.reset_memory = 1;
/* defaultly turn g_hwcursor on for both view */
--
2.53.0
next reply other threads:[~2026-10-18 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 14:15 Temitope obabi [this message]
2026-10-18 14:23 ` [PATCH] staging: sm750fb: Remove redundant zero assignments Greg Kroah-Hartman
2026-10-19 0:03 ` Temitope obabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261018141519.10165-1-obabitemitope765@gmail.com \
--to=obabitemitope765@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox