From: Greg KH <gregkh@linuxfoundation.org>
To: Platon Miller <platon.ksenzenkokk@gmail.com>
Cc: rmfrfs@gmail.com, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: light: Use sysfs_emit() instead of sprintf()
Date: Fri, 20 Nov 2026 08:07:03 +0100 [thread overview]
Message-ID: <2026112049-scouring-dimness-9d1d@gregkh> (raw)
In-Reply-To: <20261109230059.24572-1-platon.ksenzenkokk@gmail.com>
On Tue, Nov 10, 2026 at 12:00:59AM +0100, Platon Miller wrote:
> Use sysfs_emit() instead of sprintf() in sysfs show attributes
> (fade_##__dir##_show and color_show). sysfs_emit() is specifically
> designed for sysfs attributes, is PAGE_SIZE-aware, and avoids potential
> buffer overflows.
>
> Signed-off-by: Platon Miller <platon.ksenzenkokk@gmail.com>
> ---
> drivers/staging/greybus/light.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index cab02b5da..2689f9a75 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev, \
> struct led_classdev *cdev = dev_get_drvdata(dev); \
> struct gb_channel *channel = get_channel_from_cdev(cdev); \
> \
> - return sprintf(buf, "%u\n", channel->fade_##__dir); \
> + return sysfs_emit(buf, "%u\n", channel->fade_##__dir); \
> } \
> \
> static ssize_t fade_##__dir##_store(struct device *dev, \
> @@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr,
> struct led_classdev *cdev = dev_get_drvdata(dev);
> struct gb_channel *channel = get_channel_from_cdev(cdev);
>
> - return sprintf(buf, "0x%08x\n", channel->color);
> + return sysfs_emit(buf, "0x%08x\n", channel->color);
sprintf() is just fine to use here.
thanks,
greg k-h
next prev parent reply other threads:[~2026-11-20 7:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 23:00 [PATCH] staging: greybus: light: Use sysfs_emit() instead of sprintf() Platon Miller
2026-11-20 7:07 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-05 1:18 [PATCH] staging: greybus: light: use " Jacopo Di Lauro
2026-11-20 7:06 ` Greg KH
2026-10-31 8:48 Kenzema
2026-10-31 8:58 ` Greg Kroah-Hartman
2026-10-31 8:46 Ken
2026-11-03 13:50 ` Alex Elder
2026-09-20 13:38 ts930
2026-09-20 14:03 ` Greg Kroah-Hartman
[not found] ` <CAFPGN2hgqTyg+jpsY_XzbNPijV3Zce3Drw3a_c8pDBZH1hXV2w@mail.gmail.com>
2026-09-21 12:32 ` Greg Kroah-Hartman
2026-08-08 17:13 Mohit Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026112049-scouring-dimness-9d1d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=platon.ksenzenkokk@gmail.com \
--cc=rmfrfs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox