From: Jiaqi Shi <shijiaqi_develop@163.com>
To: linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-staging@lists.linux.dev
Cc: slongerbeam@gmail.com, p.zabel@pengutronix.de,
mchehab@kernel.org, gregkh@linuxfoundation.org, Frank.Li@nxp.com,
kernel@pengutronix.de, festevam@gmail.com,
Jiaqi Shi <shijiaqi_develop@163.com>
Subject: [PATCH 3/3] media: imx: allow setting FIM input capture channel
Date: Sat, 21 Nov 2026 22:14:11 +0800 [thread overview]
Message-ID: <20261121141412.319802-4-shijiaqi_develop@163.com> (raw)
In-Reply-To: <20261121141412.319802-1-shijiaqi_develop@163.com>
fim_s_ctrl() rejected all controls except V4L2_CID_IMX_FIM_ICAP_EDGE
with -EINVAL, which made V4L2_CID_IMX_FIM_ICAP_CHANNEL read-only in
practice even though it is registered as a writable control.
Add an explicit case for ICAP_CHANNEL so it can be updated, and fix
the wait_for_completion_timeout() continuation style while here.
Signed-off-by: Jiaqi Shi <shijiaqi_develop@163.com>
---
drivers/staging/media/imx/imx-media-fim.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
index b6467e29ac28..300635a3b552 100644
--- a/drivers/staging/media/imx/imx-media-fim.c
+++ b/drivers/staging/media/imx/imx-media-fim.c
@@ -58,9 +58,8 @@ static void imx_fim_wait_first_timestamp(void *priv)
struct imx_media_fim *fim = priv;
unsigned long ret;
- ret = wait_for_completion_timeout(
- &fim->icap_first_event,
- msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT));
+ ret = wait_for_completion_timeout(&fim->icap_first_event,
+ msecs_to_jiffies(IMX_MEDIA_EOF_TIMEOUT));
if (ret == 0)
v4l2_warn(fim->sd, "wait first icap event timeout\n");
}
@@ -75,6 +74,8 @@ static int fim_s_ctrl(struct v4l2_ctrl *ctrl)
if (v4l2_fim_is_streaming(fim->core))
ret = -EBUSY;
break;
+ case V4L2_CID_IMX_FIM_ICAP_CHANNEL:
+ break;
default:
ret = -EINVAL;
break;
--
2.53.0
prev parent reply other threads:[~2026-11-21 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 14:14 [PATCH 0/3] media: imx: staging cleanup and FIM export to v4l2-core Jiaqi Shi
2026-11-21 14:14 ` [PATCH 1/3] media: imx: remove legacy video node control and format handling Jiaqi Shi
2026-11-21 14:14 ` [PATCH 2/3] media: v4l2-core: add frame interval monitor helper Jiaqi Shi
2026-11-21 14:14 ` Jiaqi Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121141412.319802-4-shijiaqi_develop@163.com \
--to=shijiaqi_develop@163.com \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox