From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6FFC23A9; Sun, 6 Nov 2022 09:13:14 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id b2so23126393eja.6; Sun, 06 Nov 2022 01:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=U8zWoIusLivflIrhe/QqeEUiTBHp0weDQtpu7a3iD1sc9QTKpwALpgF1vtgRfCzikb 37wK32SeseS2JESpp01aC/H0tP0qOFSyd2ZFLVWP+RvfWoyE1KbjxaH3rxX0jkxtrlgJ D6USi7yXUC6kWqFuNsQzUPJaqoT9qZlwHyH2mQA4rILUJwQh3tpZaZbOgdAsquswiD1L p2ZpctsvirMCFQ/3saaqaii0fPnzKCyGC/7aHR+enUeY8lG7bv/DW4W44BETId09iXoa RX3yDYau3yE4BILllMhrojO6TJGi2PlX34S51wpMGtyy5OCxFuyQPOtqjporW0oe+YLD 5mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=Y+c5uQwCWFHdCCjCc5PidwB1X2n2AOdK+D6ZQ+FRD0RIHd4ALjTNViBLS74wyPKIlh bbb6QhhKOthvUM6Yc4SCa5skDOX0IlZ8fpn8dvTexJvLYwoE8V6P/VKjfk9VTMfIxil4 +gJh6ETocP5A5Iih9d8JB5zg/DDd8HcGlvkkMooSzcn3eY5fUCh8FMpyDfSx9k/KeKWb WQwxNgVomvnvXBFr0V/pidqwARvsFk9LX0c+PUJD0PGsXxGb3YuEZkjNyvfol2QqiAst 9YSzMzbdkScL7XeQbRj2ezq0QbNrdPQIpZhopBhkh1PtqR+VLriwBaSDjUvZ0VNOfQO4 3Y1w== X-Gm-Message-State: ACrzQf21u5bCwtC+NQSsvEHs7+7R4KNey5BO8/5y8TynI3gdzYb/ITh1 /cITjadCD7iFRSx0PHxy+3s= X-Google-Smtp-Source: AMsMyM7WcxErEBkvYvl5QcgwyJodv5qAgL63AB5uiIt8PX9pxynGvsrLzYqtMYJ/J3DxD2waFR33CQ== X-Received: by 2002:a17:907:a4e:b0:77d:94d:8148 with SMTP id be14-20020a1709070a4e00b0077d094d8148mr40810136ejc.607.1667725992932; Sun, 06 Nov 2022 01:13:12 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id r23-20020aa7d597000000b004638ba0ea96sm2301896edq.97.2022.11.06.01.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:13:12 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v8 6/6] media: sun6i-csi: Add support for hooking to the isp devices Date: Sun, 06 Nov 2022 10:13:11 +0100 Message-ID: <2085642.OBFZWjSADL@jernej-laptop> In-Reply-To: <20221103163717.246217-7-paul.kocialkowski@bootlin.com> References: <20221103163717.246217-1-paul.kocialkowski@bootlin.com> <20221103163717.246217-7-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 03. november 2022 ob 17:37:17 CET je Paul Kocialkowski=20 napisal(a): > In order to use the isp and csi together, both devices need to be > parented to the same v4l2 and media devices. We use the isp as > top-level device and let the csi code hook to its v4l2 and media > devices when async subdev registration takes place. >=20 > As a result v4l2/media device setup is only called when the ISP > is missing and the capture device is registered after the devices > are hooked. The bridge subdev and its notifier are registered > without any device when the ISP is available. Top-level pointers > for the devices are introduced to either redirect to the hooked ones > (isp available) or the registered ones (isp missing). >=20 > Also keep track of whether the capture node was setup or not to > avoid cleaning up resources when it wasn't. >=20 > Signed-off-by: Paul Kocialkowski Acked-by: Jernej Skrabec Best regards, Jernej