From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
phil@philpotter.co.uk, larry.finger@lwfinger.net,
julia.lawall@inria.fr, linux-kernel@vger.kernel.org,
Michael Straube <michael.straube@stud.uni-goettingen.de>,
martin@kaiser.cx
Subject: Re: [RFC] staging: r8188eu: Sleeping in atomic context (SAC) bugs
Date: Mon, 07 Feb 2022 18:17:06 +0100 [thread overview]
Message-ID: <2092556.irdbgypaU6@leap> (raw)
In-Reply-To: <23161490.ouqheUzb2q@leap>
On luned? 7 febbraio 2022 15:18:52 CET Fabio M. De Francesco wrote:
> On Mon, Feb 07, 2022 10:21:33 CET Dan Carpenter wrote:
> > On Mon, Feb 07, 2022 at 01:02:17AM +0100, Fabio M. De Francesco wrote:
>
> [...]
>
> You're right: "if (check_fwstate(pmlmepriv, _FW_LINKED))" in _rtw_pwr_wakeup()
> will prevent a call to ips_leave(). Therefore, it seems that we have no problems
> with the mutex in ips_leave().
>
> I had not noticed the above-mentioned "if" test. Sorry :(
> So, let's leave the code as it is.
I'm writing again just to be sure that I made my argument clear. When I wrote
"[] let's leave the code as it is [currently]" I was referring to the mutex_lock()
that is _never_ reached while holding the spinlock that rtw_set_802_11_disassociate()
takes before calling _rtw_pwr_wakeup().
Instead, if no one objects, I want to substitute the two "msleep(10);" with
"mdelay(10);".
However, I'll wait some time just in case someone wants to suggest a better
solution.
Fabio
> Thank you very much.
>
> Regards,
>
> Fabio M. De Francesco
>
next prev parent reply other threads:[~2022-02-07 17:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 0:02 [RFC] staging: r8188eu: Sleeping in atomic context (SAC) bugs Fabio M. De Francesco
2022-02-07 9:21 ` Dan Carpenter
2022-02-07 14:18 ` Fabio M. De Francesco
2022-02-07 17:17 ` Fabio M. De Francesco [this message]
2022-02-07 17:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2092556.irdbgypaU6@leap \
--to=fmdefrancesco@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=michael.straube@stud.uni-goettingen.de \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).