linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	gregkh@linuxfoundation.org,
	Leonardo Araujo <leonardo.aa88@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	Leonardo Araujo <leonardo.aa88@gmail.com>
Subject: Re: [PATCH] Staging: r8188eu: core: 'associcated' may be misspelled - perhaps 'associated'?
Date: Tue, 08 Feb 2022 09:09:10 +0100	[thread overview]
Message-ID: <2122312.NgBsaNRSFp@leap> (raw)
In-Reply-To: <20220207234210.26097-1-leonardo.aa88@gmail.com>

On martedì 8 febbraio 2022 00:42:10 CET Leonardo Araujo wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> CHECK: 'associcated' may be misspelled - perhaps 'associated'?
> 
> Signed-off-by: Leonardo Araujo <leonardo.aa88@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_ap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
"Staging: r8188eu: core: 'associated' may be misspelled - perhaps 'associated'?" 
it's not the way patch subjects are created for inclusion in Linux.

Please follow what is clearly described in the "Philosophy of Linux kernel 
patches" document at https://kernelnewbies.org/PatchPhilosophy...

"In patch descriptions and in the subject, it is common and preferable to use 
present-tense, imperative language. Write as if you are telling git what to do 
with your patch.".

It's not my job to accept or reject patches for this subsystem and I don't want 
to tell you what to write but, if I were you, I'd send a v2 with a subject like 
"Fix misspelled word in comments" (or something else similar to this subject).

Furthermore, please take note that the name of this subsystem is "staging" (it 
is not "Staging").

Decide by yourself whether or not the other two patches that you submitted this 
morning have to be sent anew as v2 with due changes in the subjects.

Regards,

Fabio M. De Francesco  






  reply	other threads:[~2022-02-08  8:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 23:42 [PATCH] Staging: r8188eu: core: 'associcated' may be misspelled - perhaps 'associated'? Leonardo Araujo
2022-02-08  8:09 ` Fabio M. De Francesco [this message]
2022-02-08  8:26   ` Greg KH
2022-02-08  8:56     ` Fabio M. De Francesco
2022-02-08 10:54       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2122312.NgBsaNRSFp@leap \
    --to=fmdefrancesco@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=leonardo.aa88@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).