From: Dan Carpenter <dan.carpenter@linaro.org>
To: Riyan Dhiman <riyandhiman14@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8192e: Rename variable eRFPath
Date: Sat, 31 Aug 2024 18:14:50 +0300 [thread overview]
Message-ID: <225c7675-3526-40a3-ae9d-877ff8e4f250@stanley.mountain> (raw)
In-Reply-To: <20240831145932.37744-1-riyandhiman14@gmail.com>
On Sat, Aug 31, 2024 at 08:29:32PM +0530, Riyan Dhiman wrote:
> Rename variable eRFPath to erf_path to fix checkpatch
> warning.
>
> Issue reported in checkpatch:
> -CHECK: Avoid CamelCase: <eRFPath>
>
> Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
> ---
> .../staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 7061f1cf4d3a..256c19739ad1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> @@ -12,7 +12,7 @@
> void rtl92e_set_bandwidth(struct net_device *dev,
> enum ht_channel_width bandwidth)
> {
> - u8 eRFPath;
> + u8 erf_path;
e stands for enum. We don't like this kind of name. Just call it rf_path.
regards,
dan carpenter
prev parent reply other threads:[~2024-08-31 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 14:59 [PATCH] staging: rtl8192e: Rename variable eRFPath Riyan Dhiman
2024-08-31 15:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225c7675-3526-40a3-ae9d-877ff8e4f250@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=riyandhiman14@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox