Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove camelcase in several files

["Fabio M. De Francesco" <fmdefrancesco@gmail.com>]

On Thursday, April 8, 2021 10:36:32 AM CEST Greg KH wrote:
> On Thu, Apr 08, 2021 at 10:07:14AM +0200, Fabio M. De Francesco wrote:
> > Remove camelcase in a symbol that is used by several files.
> 
> What symbol?
> 

I'm not sure I understand what you are asking. You mean
that I have to specify the name of the variable that I changed?
Or you mean that I shouldn't use the term "symbol" but write
"variable", "function", "macro", and so on?

>
> > --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
> > +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h
> > @@ -203,7 +203,7 @@ struct pwrctrl_priv {
> >  	u8 LpsIdleCount;
> >  	u8 power_mgnt;
> >  	u8 org_power_mgnt;
> > -	u8 bFwCurrentInPSMode;
> > +	u8 b_fw_current_in_ps_mode;
> 
> The "b" here means "byte" so you can drop the "b_" as that means
> nothing, we do not use this type of notation in the kernel as the
> compiler can check it for us.
>

OK, I didn't know what the 'b' meant in this context. I'll drop it.

Thanks,

Fabio
 
> thanks,
> 
> greg k-h
>