From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH 2/2] staging: r8188eu: Make some clean-ups in usbctrl_vendorreq()
Date: Tue, 24 Aug 2021 17:39:31 +0200 [thread overview]
Message-ID: <2327592.S5L5zkRU50@localhost.localdomain> (raw)
In-Reply-To: <17234f07-debc-5b6c-244d-472a3f33bc3f@gmail.com>
On Tuesday, August 24, 2021 5:26:23 PM CEST Pavel Skripkin wrote:
> I found the problem:
>
> > mutex_lock(&dvobjpriv->usb_vendor_req_mutex);
> >
> > /* Acquire IO memory for vendorreq */
> > - pIo_buf = dvobjpriv->usb_vendor_req_buf;
> > + io_buf = dvobjpriv->usb_vendor_req_buf;
>
>
> I don't know from where mutex_lock() comes from. In staging-next I have
>
> _enter_critical_mutex(&dvobjpriv->usb_vendor_req_mutex, NULL);
>
> instead of
>
> mutex_lock(&dvobjpriv->usb_vendor_req_mutex);
>
Oh, I know where it comes from... :)
It's a patch of mine that is in the queue, waiting to be reviewed and applied.
Please see: https://lore.kernel.org/lkml/20210819221241.31987-1-fmdefrancesco@gmail.com/
Thanks,
Fabio
>
> With regards,
> Pavel Skripkin
>
next prev parent reply other threads:[~2021-08-24 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 14:28 [PATCH v2 0/2] staging: r8188eu: Use new usb_control_msg_recv/send() Fabio M. De Francesco
2021-08-24 14:28 ` [PATCH v2 1/2] staging: r8188eu: Use usb_control_msg_recv/send() in usbctrl_vendorreq() Fabio M. De Francesco
2021-08-24 14:35 ` Pavel Skripkin
2021-08-24 15:23 ` Fabio M. De Francesco
2021-08-24 22:16 ` Phillip Potter
2021-08-24 14:28 ` [PATCH 2/2] staging: r8188eu: Make some clean-ups " Fabio M. De Francesco
2021-08-24 14:39 ` Pavel Skripkin
2021-08-24 15:15 ` Fabio M. De Francesco
2021-08-24 15:26 ` Pavel Skripkin
2021-08-24 15:39 ` Fabio M. De Francesco [this message]
2021-08-24 15:43 ` Pavel Skripkin
2021-08-24 15:59 ` Fabio M. De Francesco
2021-08-24 16:04 ` Pavel Skripkin
2021-08-24 16:18 ` Greg Kroah-Hartman
2021-08-24 16:24 ` Pavel Skripkin
2021-08-24 22:20 ` Phillip Potter
-- strict thread matches above, loose matches on Subject: below --
2021-08-23 22:37 [PATCH 0/2] staging: r8188eu: Use new usb_control_msg_recv/send() Fabio M. De Francesco
2021-08-23 22:37 ` [PATCH 2/2] staging: r8188eu: Make some clean-ups in usbctrl_vendorreq() Fabio M. De Francesco
2021-08-24 0:10 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2327592.S5L5zkRU50@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox