From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Tree Davies <tdavies@darkphysics.net>,
gregkh@linuxfoundation.org, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/20] Staging: rtl8192e: Rename function rtllib_rx_ADDBAReq()
Date: Mon, 26 Feb 2024 17:59:15 +0100 [thread overview]
Message-ID: <236c7275-c8db-4ed8-9568-dd21c5834fc9@gmail.com> (raw)
In-Reply-To: <20240226035624.370443-2-tdavies@darkphysics.net>
On 2/26/24 04:56, Tree Davies wrote:
> Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch
> warning Avoid CamelCase.
>
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
description?)
#7:
Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch
> Signed-off-by: Tree Davies <tdavies@darkphysics.net>
> ---
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +-
> drivers/staging/rtl8192e/rtllib.h | 2 +-
> drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index da7319c124e7..bd1d86e0323d 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -211,7 +211,7 @@ static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst,
> netdev_dbg(ieee->dev, "Failed to generate DELBA packet.\n");
> }
>
> -int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> +int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb)
> {
> struct ieee80211_hdr_3addr *req = NULL;
> u16 rc = 0;
> diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
> index 348644998744..95a8e9416f61 100644
> --- a/drivers/staging/rtl8192e/rtllib.h
> +++ b/drivers/staging/rtl8192e/rtllib.h
> @@ -1771,7 +1771,7 @@ u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame);
> void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
> bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
> u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
> -int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
> +int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb);
> int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb);
> void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts,
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 2545ac8963c4..f12ee685e989 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1551,7 +1551,7 @@ static void rtllib_process_action(struct rtllib_device *ieee,
> case ACT_CAT_BA:
> switch (*act) {
> case ACT_ADDBAREQ:
> - rtllib_rx_ADDBAReq(ieee, skb);
> + rtllib_rx_add_ba_req(ieee, skb);
> break;
> case ACT_ADDBARSP:
> rtllib_rx_add_ba_rsp(ieee, skb);
next prev parent reply other threads:[~2024-02-26 16:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 3:56 [PATCH 00/20] Staging: rtl8192e: Fix checkpatch warning for rtllib_softmac.c Tree Davies
2024-02-26 3:56 ` [PATCH 01/20] Staging: rtl8192e: Rename function rtllib_rx_ADDBAReq() Tree Davies
2024-02-26 16:59 ` Philipp Hortmann [this message]
2024-02-26 3:56 ` [PATCH 02/20] Staging: rtl8192e: Rename variable NumRecvDataInPeriod Tree Davies
2024-02-26 3:56 ` [PATCH 03/20] Staging: rtl8192e: Rename function SecIsInPMKIDList() Tree Davies
2024-02-26 3:56 ` [PATCH 04/20] Staging: rtl8192e: Rename variable PMKIDList Tree Davies
2024-02-26 3:56 ` [PATCH 05/20] Staging: rtl8192e: Rename variable Turbo_Enable Tree Davies
2024-02-26 3:56 ` [PATCH 06/20] Staging: rtl8192e: Rename variable osCcxRmCap Tree Davies
2024-02-26 3:56 ` [PATCH 07/20] Staging: rtl8192e: Rename variable bCkipSupported Tree Davies
2024-02-26 3:56 ` [PATCH 08/20] Staging: rtl8192e: Rename variable bCcxRmEnable Tree Davies
2024-02-26 3:56 ` [PATCH 09/20] Staging: rtl8192e: Rename variable CcxRmCapBuf Tree Davies
2024-02-26 3:56 ` [PATCH 10/20] Staging: rtl8192e: Rename variable BssCcxVerNumber Tree Davies
2024-02-26 3:56 ` [PATCH 11/20] Staging: rtl8192e: Rename variable CcxVerNumBuf Tree Davies
2024-02-26 3:56 ` [PATCH 12/20] Staging: rtl8192e: Rename variable asRsn Tree Davies
2024-02-26 3:56 ` [PATCH 13/20] Staging: rtl8192e: Rename variable AironetIeOui Tree Davies
2024-02-26 3:56 ` [PATCH 14/20] Staging: rtl8192e: Rename variable osCcxAironetIE Tree Davies
2024-02-26 3:56 ` [PATCH 15/20] Staging: rtl8192e: Rename variable CcxAironetBuf Tree Davies
2024-02-26 3:56 ` [PATCH 16/20] Staging: rtl8192e: Rename varoable osCcxVerNum Tree Davies
2024-02-26 3:56 ` [PATCH 17/20] Staging: rtl8192e: Rename varoable asSta Tree Davies
2024-02-26 3:56 ` [PATCH 18/20] Staging: rtl8192e: Rename reference AllowAllDestAddrHandler Tree Davies
2024-02-26 3:56 ` [PATCH 19/20] Staging: rtl8192e: Rename boolean variable bHalfWirelessN24GMode Tree Davies
2024-02-26 3:56 ` [PATCH 20/20] Staging: rtl8192e: Rename function MgntQuery_MgntFrameTxRate Tree Davies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236c7275-c8db-4ed8-9568-dd21c5834fc9@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tdavies@darkphysics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox