Re: [PATCH] staging: rtl8723bs: core: Refactor nested if-else

Fabio M. De Francesco
2021-10-25T10:02:32Z

On Monday, October 25, 2021 9:56:00 AM CEST kushal kothari wrote:
> >Very long line, please break it up at 72 columns.
>
> >And your space around the '.' is odd :(
>
> Yes,fixing it.
>
^^^^^^^^^^^^^^^^^^^^

You are still using spaces the wrong way :)

English, as well as all natural languages that use Latin characters, use
punctuation and a strict style that dictates how to use the spaces around it.
Please read correctly written English texts, learn and use conventions

Thanks,

Fabio
>
> >> checkpatch warning : Too many leading tabs - consider code refactoring
>
> >What does this mean?
> Asking about the warning ,correct?
> The current code is using very deep indentations (which can be avoided) and
> due to this there are many leading tabs. So the checkpatch.pl warns of
"Too
> many leading tabs - consider code refactoring"
> <http://checkpatch.pl>
>
> On Mon, Oct 25, 2021 at 1:03 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Mon, Oct 25, 2021 at 12:55:28PM +0530, Kushal Kothari wrote:
> > > Refactor nested if else by combining nested if into a single if
> > condition and removing unnecessary else conditionals which leads to
> > removing unnecessary tabs .There is no change in logic of new code.
> >
> > Very long line, please break it up at 72 columns.
> >
> > And your space around the '.' is odd :(
> >
> > > checkpatch warning : Too many leading tabs - consider code refactoring
> >
> > What does this mean?
> >
> > >
> > > Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> > > ---
> > > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 65 ++++++++-----------
> > > 1 file changed, 26 insertions(+), 39 deletions(-)
> > >
> >
> > thanks,
> >
> > greg k-h
> >
>