Re: [PATCH] staging: rtl8723bs: core: Refactor nested if-else

Greg KH
2021-10-25T07:33:19Z

On Mon, Oct 25, 2021 at 12:55:28PM +0530, Kushal Kothari wrote:
> Refactor nested if else by combining nested if into a single if condition and removing unnecessary else conditionals which leads to removing unnecessary tabs .There is no change in logic of new code.

Very long line, please break it up at 72 columns.

And your space around the '.' is odd :(

> checkpatch warning : Too many leading tabs - consider code refactoring

What does this mean?

>
> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 65 ++++++++-----------
> 1 file changed, 26 insertions(+), 39 deletions(-)
>

thanks,

greg k-h