public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [BUG] staging: rtl8192e: W_DISABLE# does not work after stop/start
Date: Fri, 7 Apr 2023 23:02:05 +0200	[thread overview]
Message-ID: <248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com> (raw)
In-Reply-To: <39dc735c-fd6d-e405-856c-788a52704d63@gmail.com>

When loading the driver for rtl8192e, the W_DISABLE# switch is working 
as intended. But when the WLAN is turned off in software and then turned 
on again the W_DISABLE# does not work anymore.

Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio()
checking this every two seconds is an conditional return.

	if (priv->bfirst_after_down) {
		priv->bfirst_after_down = true; // PH: useless line
		return;
	}

	tmp1byte = rtl92e_readb(dev, GPI); // PH: GPI for W_DISABLE#

bfirst_after_down is set true when switching the WLAN off in software. 
But it is not set to false again when WLAN is turned on again.

Thanks for your support.

Bye Philipp


  parent reply	other threads:[~2023-04-07 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-02 15:00 [BUG] staging: rtl8192e: oops occurs when finding hardware rtl8192se Philipp Hortmann
2023-04-05 14:37 ` Greg Kroah-Hartman
2023-04-05 21:19   ` Philipp Hortmann
2023-04-07 21:02 ` Philipp Hortmann [this message]
2023-04-13  9:34   ` [BUG] staging: rtl8192e: W_DISABLE# does not work after stop/start Dan Carpenter
2023-04-13 22:17     ` Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox