From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3260F71 for ; Mon, 12 Apr 2021 10:23:10 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id s15so14401344edd.4 for ; Mon, 12 Apr 2021 03:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aDYfwXOX7CXJC5km5DlusEFEF+Nl5xWOkbGcpQvebPk=; b=dpot/PDuWTxI0+YsjLFgYLzDEj6vgBZZXMNrC5eNX2r5KNR9iKUMwbnVJ3BjT1vNex wSvgO0xYpng6v2cvxlxxCRq11pcF/DE7hoSDUMbKXRYT5KekR45y2Nq3ysC2ZIpwD60A x+KcjDBwQquu8oosqncOGLRy67S0T+CGgm5HKD0eYbk3vjCK16gkdUWxSGGMFA3Gw2th ddF2dtSOkIIa4diivQ++lhGNuGwicsn/6RariSY8/whcfMdjuc+3Z34zZ9WM2DMKn7WP fzyFLCHBvMhd4M8K/hPezvjDvD0xXIUs4cBCHSOoMqUHN0fT7ioOasbstn/+FxMfg4Ey Q+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aDYfwXOX7CXJC5km5DlusEFEF+Nl5xWOkbGcpQvebPk=; b=bVTS19yZmSAybqfs9k5+33VvCofu3VkmRgKPOof3FrViw0BQWMDkLQiX527IeOyIOO ynXzY3g+eyZBHXeRZ7RcX8lO3oRm4X71nCQQorqqv4ws6cD9CsS2SAyc5WO/0dZpX0vC Cf+vdrG3Zo5rdyEBpi5bYFo2+tHBNg2zgX5Ligqy0hMLgRhvVhLf/vj+OxQukm822v9l VuT58nSg+sxaI1Yfm9GXXXYMYIyWgjhQvIIXKlzDLPiwHGWeH6ki/gm2O4KKikB21kJp UeIXkQhRUVPCy5yWeHJdlmnqfi28fbHzQzzsJ9CehotoLr9fkFOscEFGr4tW9TBk4T0v 3qFg== X-Gm-Message-State: AOAM530K3xgOO+Dbl6pYYWpiYZ8LkpxfT+XSVA6cwH1wD7Rga+Z06w0b cFw+En/Qa3q0eFNH6GXhCio= X-Google-Smtp-Source: ABdhPJzcBYWukqy9abedu05uFLTelTQXauXhdaT4/d0FJPiqlSsW5qbhAnCE5YHP5PV2lJdpDCi/2g== X-Received: by 2002:a05:6402:2691:: with SMTP id w17mr21565207edd.81.1618222988753; Mon, 12 Apr 2021 03:23:08 -0700 (PDT) Received: from linux.local (host-95-237-55-30.retail.telecomitalia.it. [95.237.55.30]) by smtp.gmail.com with ESMTPSA id w13sm6134925edc.81.2021.04.12.03.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 03:23:08 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg KH Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used Date: Mon, 12 Apr 2021 12:23:07 +0200 Message-ID: <269706412.I7xuoi7Q6o@linux.local> In-Reply-To: References: <20210411174143.31618-1-fmdefrancesco@gmail.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, April 12, 2021 11:31:15 AM CEST Greg KH wrote: > On Sun, Apr 11, 2021 at 07:41:43PM +0200, Fabio M. De Francesco wrote: > > Remove variable "int ret" which is instantiated but not used. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > > > drivers/staging/rtl8192u/r8192U_core.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192u/r8192U_core.c > > b/drivers/staging/rtl8192u/r8192U_core.c index > > f48186a89fa1..30055de66239 100644 > > --- a/drivers/staging/rtl8192u/r8192U_core.c > > +++ b/drivers/staging/rtl8192u/r8192U_core.c > > @@ -902,7 +902,6 @@ static void rtl8192_hard_data_xmit(struct sk_buff > > *skb, struct net_device *dev,> > > int rate) > > > > { > > > > struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev); > > > > - int ret; > > > > unsigned long flags; > > struct cb_desc *tcb_desc = (struct cb_desc *)(skb->cb + > > MAX_DEV_ADDR_SIZE); u8 queue_index = tcb_desc->queue_index; > > Did you test-build this patch? > Sorry, I don't know why I forgot to test it. I realized that this morning when I read a message from the kernel test robot. I'll be more careful with future patches. Thanks, Fabio