public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] fbtft: Remove access to page->index
Date: Fri, 21 Feb 2025 17:53:16 +0000	[thread overview]
Message-ID: <27cc53b9-0db7-451c-9136-5fdcf42145f7@lucifer.local> (raw)
In-Reply-To: <20250221173131.3470667-1-willy@infradead.org>

On Fri, Feb 21, 2025 at 05:31:29PM +0000, Matthew Wilcox (Oracle) wrote:
> There is no need to print out page->index as part of the debug message.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

LGTM from my side,

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

> ---
>  drivers/staging/fbtft/fbtft-core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 4cfa494243b9..da9c64152a60 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -337,9 +337,7 @@ static void fbtft_deferred_io(struct fb_info *info, struct list_head *pagereflis
>  	list_for_each_entry(pageref, pagereflist, list) {
>  		y_low = pageref->offset / info->fix.line_length;
>  		y_high = (pageref->offset + PAGE_SIZE - 1) / info->fix.line_length;
> -		dev_dbg(info->device,
> -			"page->index=%lu y_low=%d y_high=%d\n",
> -			pageref->page->index, y_low, y_high);
> +		dev_dbg(info->device, "y_low=%d y_high=%d\n", y_low, y_high);
>  		if (y_high > info->var.yres - 1)
>  			y_high = info->var.yres - 1;
>  		if (y_low < dirty_lines_start)
> --
> 2.47.2
>

  reply	other threads:[~2025-02-21 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 17:31 [PATCH] fbtft: Remove access to page->index Matthew Wilcox (Oracle)
2025-02-21 17:53 ` Lorenzo Stoakes [this message]
2025-03-04 16:21   ` Matthew Wilcox
2025-03-05  7:39     ` Simona Vetter
2025-03-05 17:49       ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27cc53b9-0db7-451c-9136-5fdcf42145f7@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tzimmermann@suse.de \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox