From: weibu@redadmin.org
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: xmit: fix grammar in comment
Date: Wed, 17 Sep 2025 15:23:18 +0900 [thread overview]
Message-ID: <2a4eef3ad872c923be7b0070056b5a8b@redadmin.org> (raw)
In-Reply-To: <2025091705-murky-sage-465f@gregkh>
Thanks, Greg.
Sorry for the off-list reply; resending to the lists.
You're right about the extra space; I dropped it. To avoid the "number
of"
confusion I rephrased the sentence to "Total page count is not
available, so
update current FIFO status." Sent as v2.
Best,
Akiyoshi
2025-09-17 14:52 に Greg KH さんは書きました:
> On Wed, Sep 17, 2025 at 02:39:44PM +0900, Akiyoshi Kurita wrote:
>> Fix 'number of page' -> 'number of pages' in a comment.
>>
>> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
>> ---
>> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> index 842e19b53421..7ba8981f4652 100644
>> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
>> @@ -76,7 +76,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter
>> *padapter)
>> /* check if hardware tx fifo page is enough */
>> if (!rtw_hal_sdio_query_tx_freepage(pri_padapter, PageIdx,
>> pxmitbuf->pg_num)) {
>> if (!bUpdatePageNum) {
>> - /* Total number of page is NOT available, so update current FIFO
>> status */
>> + /* Total number of pages is NOT available, so update current FIFO
>> status */
>
> As "pages" is now plural, shouldn't "is" become "are"?
>
> Also, you can drop the extra leading space in the comment.
>
> thanks,
>
> greg "english grammer is rough" k-h
next prev parent reply other threads:[~2025-09-17 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 5:39 [PATCH] staging: rtl8723bs: xmit: fix grammar in comment Akiyoshi Kurita
2025-09-17 5:52 ` Greg KH
2025-09-17 6:23 ` weibu [this message]
2025-09-17 6:37 ` [PATCH v2] staging: rtl8723bs: xmit: rephrase comment and drop extra space Akiyoshi Kurita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4eef3ad872c923be7b0070056b5a8b@redadmin.org \
--to=weibu@redadmin.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox