From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>,
outreachy@lists.linux.dev, julia.lawall@inria.fr,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, andy@kernel.org
Subject: Re: [v3 1/1] staging: rtl8723bs: Prevent duplicate NULL tests on a value
Date: Fri, 4 Apr 2025 14:47:14 +0300 [thread overview]
Message-ID: <2aa7d5da-c53c-4bab-8fbf-2caebddc9b7a@stanley.mountain> (raw)
In-Reply-To: <CAHp75VfDOaK0EXNc79cM1mNWapm7fhshU550q1mAKQdtRbUNwg@mail.gmail.com>
On Fri, Apr 04, 2025 at 01:53:16PM +0300, Andy Shevchenko wrote:
> > Also if the change accidentally introduces a bug, I want it to be a
> > one liner change and not something hidden inside a giant reformat.
>
> The noisy {] have no point to be left. Now I'm curious, what do you
> propose here?
The patch *must* remove the { and }. We wouldn't have accepted the v1
patch.
regards,
dan carpenter
next prev parent reply other threads:[~2025-04-04 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 0:02 [v3 0/1] Unnecessary code cleanup patches Abraham Samuel Adekunle
2025-04-04 0:02 ` [v3 1/1] staging: rtl8723bs: Prevent duplicate NULL tests on a value Abraham Samuel Adekunle
2025-04-04 7:53 ` Andy Shevchenko
2025-04-04 7:58 ` Samuel Abraham
2025-04-04 9:06 ` Dan Carpenter
2025-04-04 10:13 ` Samuel Abraham
2025-04-04 10:53 ` Andy Shevchenko
2025-04-04 11:47 ` Dan Carpenter [this message]
2025-04-05 8:36 ` [v3 0/1] Unnecessary code cleanup patches Greg KH
2025-04-05 8:49 ` Julia Lawall
2025-04-05 11:18 ` Samuel Abraham
2025-04-05 11:15 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aa7d5da-c53c-4bab-8fbf-2caebddc9b7a@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=abrahamadekunle50@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox