public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Charalampos Mitrodimas <charmitro@posteo.net>
To: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Cc: skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev,
	 gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de,
	 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-staging@lists.linux.dev, Michael.Hennerich@analog.com
Subject: Re: [PATCH] iio: frequency:: Remove unused parameter from data documentation
Date: Thu, 17 Apr 2025 15:57:48 +0000	[thread overview]
Message-ID: <2cc70f19c1b001ea7f2cf0632618d060f69faef0.camel@posteo.net> (raw)
In-Reply-To: <56edfb88d3f31939fb343149bfad436f24671f9d.camel@posteo.net>

On Thu, 2025-04-17 at 15:53 +0000, Charalampos Mitrodimas wrote:
> On Thu, 2025-04-17 at 10:32 -0400, Gabriel Shahrouzi wrote:
> > The AD9832 driver uses the Common Clock Framework (CCF) to obtain
> > the
> > master clock (MCLK) frequency rather than relying on a frequency
> > value
> > passed from platform data.
> > 
> > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com>
> > ---
> >  drivers/staging/iio/frequency/ad9832.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/staging/iio/frequency/ad9832.h
> > b/drivers/staging/iio/frequency/ad9832.h
> > index 98dfbd9289ab8..d0d840edb8d27 100644
> > --- a/drivers/staging/iio/frequency/ad9832.h
> > +++ b/drivers/staging/iio/frequency/ad9832.h
> > @@ -13,7 +13,6 @@
> >  
> >  /**
> >   * struct ad9832_platform_data - platform specific information
> > - * @mclk:              master clock in Hz
> 
> Hi Gabriel,
> 
> This seems to be a leftover from
> 566564e80b0ed23ffa4c40f7ad4224bf3327053a ("staging: iio: ad9832: use
> clock framework for clock reference")

That said, a Fixes: tag might be helpful?

> 
> 
> 
> >   * @freq0:             power up freq0 tuning word in Hz
> >   * @freq1:             power up freq1 tuning word in Hz
> >   * @phase0:            power up phase0 value [0..4095] correlates
> > with 0..2PI
> 
> 


  reply	other threads:[~2025-04-17 15:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 14:32 [PATCH] iio: frequency:: Remove unused parameter from data documentation Gabriel Shahrouzi
2025-04-17 15:53 ` Charalampos Mitrodimas
2025-04-17 15:57   ` Charalampos Mitrodimas [this message]
2025-04-17 16:47     ` Jonathan Cameron
2025-04-17 17:17     ` Gabriel Shahrouzi
2025-04-17 17:26       ` Charalampos Mitrodimas
2025-04-17 16:17 ` David Lechner
2025-04-17 17:22   ` Gabriel Shahrouzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cc70f19c1b001ea7f2cf0632618d060f69faef0.camel@posteo.net \
    --to=charmitro@posteo.net \
    --cc=Michael.Hennerich@analog.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gshahrouzi@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox