Re: [PATCH v2] staging: rtl8723bs: Use % 4096 instead of & 0xfff

Greg Kroah-Hartman
2025-04-05T08:23:40Z

On Sat, Apr 05, 2025 at 12:09:59AM +0000, Abraham Samuel Adekunle wrote:
> Replace the bitwise AND operator `&` with a modulo
> operator `%` and decimal number to make the upper limit visible
> and clear what the semantic of it is.

Eeek, no. We all "know" what & means (it's a bit mask to handle the
issues involved), and we all do NOT know that % will do the same thing
at all.

So this just made things more difficult to maintain over time.

What tool suggested this type of change to be made to this driver and
these lines?

thanks,

greg k-h