From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v3] staging: greybus: use inline function for macros
Date: Mon, 20 Mar 2023 20:27:36 +0200 [thread overview]
Message-ID: <2d991001-0d31-988b-fbfd-c6c2452adcc0@gmail.com> (raw)
In-Reply-To: <ZBh+3W4eTL9IMW3n@kroah.com>
On ٢٠/٣/٢٠٢٣ ١٧:٤٢, Greg KH wrote:
> On Mon, Mar 20, 2023 at 12:32:58PM +0200, Menna Mahmoud wrote:
>> Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a
>> static inline function.
>>
>> it is not great to have macro that use `container_of` macro,
>> because from looking at the definition one cannot tell what type
>> it applies to.
>>
>> One can get the same benefit from an efficiency point of view
>> by making an inline function.
>>
>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ---
>> change in v2:
>> remove newlines added in previous patch.
>>
>> change in v3:
>> fix the patch to be against Greg's tree.
> I am lost in a twisty maze of patches from you for the greybus code that
> all seem alike but are different :(
I am sorry for that.
> Can you send a patch series of the latest changes you have made, as I
> really don't know what is, and is not, the latest versions at all, so
> I'm going to have to drop them all from my review queue right now.
Sure, I will.
>
> thanks,
>
> greg k-h
Thanks,
Menna
prev parent reply other threads:[~2023-03-20 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:32 [PATCH v3] staging: greybus: use inline function for macros Menna Mahmoud
2023-03-20 15:42 ` Greg KH
2023-03-20 18:27 ` Menna Mahmoud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d991001-0d31-988b-fbfd-c6c2452adcc0@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox