Re: [PATCH 1/2] staging: vc04_services: Drop completed TODO item

[Stefan Wahren <wahrenst@gmx.net>]

Hi Umang,

i hope it's okay to add the most of the recipients again.

Am 26.10.23 um 14:42 schrieb Umang Jain:
> Hi Stefan
>
> On 10/25/23 10:16 PM, Stefan Wahren wrote:
>> Hi Umang,
>>
>> Am 25.10.23 um 12:32 schrieb Umang Jain:
>>> Drop the TODO item which deals with non-essential global
>>> structures and per-device structure. All this has been
>>> handled now through vchiq-bus and struct vchiq_device.
>>>
>>> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
>>> ---
>>>   drivers/staging/vc04_services/interface/TODO | 8 --------
>>>   1 file changed, 8 deletions(-)
>>>
>>> diff --git a/drivers/staging/vc04_services/interface/TODO
>>> b/drivers/staging/vc04_services/interface/TODO
>>> index 6d9d4a800aa7..9c79ed549831 100644
>>> --- a/drivers/staging/vc04_services/interface/TODO
>>> +++ b/drivers/staging/vc04_services/interface/TODO
>>> @@ -46,14 +46,6 @@ The code follows the 80 characters limitation yet
>>> tends to go 3 or 4 levels of
>>>   indentation deep making it very unpleasant to read. This is
>>> specially relevant
>>>   in the character driver ioctl code and in the core thread functions.
>>>
>>> -* Get rid of all non essential global structures and create a
>>> proper per
>>> -device structure
>> at first thank for all the great work. Currently i don't have much time
>> to give a feedback for everything :-(
>
> No worries. As long as things are progressing, I don't mind.
>>
>> Tbh this TODO is not finished yet. There are still global structures.
>> Please look at variables starting with g_* in vchiq_arm.c and
>> vchiq_connected.c
>>
>
> Ah just saw them now. Oh god, these are a pain.
>> Unfortunately i cannot tell which of them are easy to move into the
>> device structure.
>
> Indeed. I don't have much time left this week, so probably I'll start
> developing something over next week. :-/
>
> Also do you know where I can find some overview documentation of the
> driver itself? I don't think I understand the details of "how this
> driver is supposed to function" in the first place.
unfortunately this is the reason for point 4 in the TODO list.

In the past i started a request in the Raspberry Pi github [1], but i
didn't get a fully satisfying response. Maybe this kind of documentation
is under NDA.

I vaguely remember of a little bit documentation on Github, but it
wasn't specific to the Linux driver.

[1] - https://github.com/raspberrypi/linux/issues/2730