[PATCH] Staging: r8188eu: Fixed block comment

[PATCH] Staging: r8188eu: Fixed block comment

[Khadija Kamran]

Fixed block comment by adding '*' in each line. The Check message was
shown by using checkpatch.pl script.

Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
index a7c67014dde0..03025dc89533 100644
--- a/drivers/staging/r8188eu/core/rtw_br_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
@@ -36,15 +36,16 @@
 #define WAIT_TIME_PPPOE	5	/*  waiting time for pppoe server in sec */
 
 /*-----------------------------------------------------------------
-  How database records network address:
-	   0    1    2    3    4    5    6    7    8    9   10
-	|----|----|----|----|----|----|----|----|----|----|----|
-  IPv4  |type|                             |      IP addr      |
-  IPX   |type|      Net addr     |          Node addr          |
-  IPX   |type|      Net addr     |Sckt addr|
-  Apple |type| Network |node|
-  PPPoE |type|   SID   |           AC MAC            |
------------------------------------------------------------------*/
+ * How database records network address:
+ *	    0    1    2    3    4    5    6    7    8    9   10
+ *	 |----|----|----|----|----|----|----|----|----|----|----|
+ * IPv4  |type|                             |      IP addr      |
+ * IPX   |type|      Net addr     |          Node addr          |
+ * IPX   |type|      Net addr     |Sckt addr|
+ * Apple |type| Network |node|
+ * PPPoE |type|   SID   |           AC MAC            |
+ * ----------------------------------------------------------------
+ */
 
 /* Find a tag in pppoe frame and return the pointer */
 static unsigned char *__nat25_find_pppoe_tag(struct pppoe_hdr *ph, unsigned short type)
-- 
2.34.1

Re: [PATCH] Staging: r8188eu: Fixed block comment

[Philipp Hortmann]

On 2/17/23 08:17, Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index a7c67014dde0..03025dc89533 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -36,15 +36,16 @@
>   #define WAIT_TIME_PPPOE	5	/*  waiting time for pppoe server in sec */
>   
>   /*-----------------------------------------------------------------
> -  How database records network address:
> -	   0    1    2    3    4    5    6    7    8    9   10
> -	|----|----|----|----|----|----|----|----|----|----|----|
> -  IPv4  |type|                             |      IP addr      |
> -  IPX   |type|      Net addr     |          Node addr          |
> -  IPX   |type|      Net addr     |Sckt addr|
> -  Apple |type| Network |node|
> -  PPPoE |type|   SID   |           AC MAC            |
> ------------------------------------------------------------------*/
> + * How database records network address:
> + *	    0    1    2    3    4    5    6    7    8    9   10
> + *	 |----|----|----|----|----|----|----|----|----|----|----|
> + * IPv4  |type|                             |      IP addr      |
> + * IPX   |type|      Net addr     |          Node addr          |
> + * IPX   |type|      Net addr     |Sckt addr|
> + * Apple |type| Network |node|
> + * PPPoE |type|   SID   |           AC MAC            |
> + * ----------------------------------------------------------------
> + */
>   
>   /* Find a tag in pppoe frame and return the pointer */
>   static unsigned char *__nat25_find_pppoe_tag(struct pppoe_hdr *ph, unsigned short type)

Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

Re: [PATCH] Staging: r8188eu: Fixed block comment

[Greg KH]

On Fri, Feb 17, 2023 at 07:17:00AM +0000, Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

This driver is now deleted, so this will not apply for obvious reasons.

thanks,

greg k-h

Re: [PATCH] Staging: r8188eu: Fixed block comment

[Fabio M. De Francesco]

On venerdì 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> Fixed block comment by adding '*' in each line. The Check message was
> shown by using checkpatch.pl script.
> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 

Hi Khadija,

As Greg said this driver is not here any longer. This makes me think that you 
forgot at least two things...

1) Please pull and rebase the staging tree every day while working on patches 
during this period of the Outreachy project. If you had done so, you would 
have noticed that your patch cannot any more be applied.

2) I saw this patch by pure luck because you forgot to Cc the Outreachy list. 
Therefore, please don't ever forget to Cc that list. Most mentors don't 
subscribe the linux-staging list.

Thanks,

Fabio

P.S.: Please use an imperative tone, both in the subject and in the commit 
message. For example this patch could have been written the following way:

staging: axis-fifo: Add "*" to multi-line comment

Add asterisks to each line of a multi-line comment to conform to the Linux 
development guidelines. Warning reported by checkpatch.pl.

Signed-off-by: [...]

Re: [PATCH] Staging: r8188eu: Fixed block comment

[Dan Carpenter]

On Fri, Mar 10, 2023 at 12:52:55PM +0100, Fabio M. De Francesco wrote:
> On venerdì 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> > Fixed block comment by adding '*' in each line. The Check message was
> > shown by using checkpatch.pl script.
> > 
> > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > ---
> >  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> >  1 file changed, 10 insertions(+), 9 deletions(-)
> > 
> 
> Hi Khadija,
> 
> As Greg said this driver is not here any longer. This makes me think that you 
> forgot at least two things...
> 
> 1) Please pull and rebase the staging tree every day while working on patches 
> during this period of the Outreachy project. If you had done so, you would 
> have noticed that your patch cannot any more be applied.

This patch was sent long before the driver was deleted...  The patch was
fine and would have been applied if the driver hadn't been removed.

regards,
dan carpenter

Re: [PATCH] Staging: r8188eu: Fixed block comment

[Fabio M. De Francesco]

On venerdì 10 marzo 2023 13:09:54 CET Dan Carpenter wrote:
> On Fri, Mar 10, 2023 at 12:52:55PM +0100, Fabio M. De Francesco wrote:
> > On venerdì 17 febbraio 2023 08:17:00 CET Khadija Kamran wrote:
> > > Fixed block comment by adding '*' in each line. The Check message was
> > > shown by using checkpatch.pl script.
> > > 
> > > Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> > > ---
> > > 
> > >  drivers/staging/r8188eu/core/rtw_br_ext.c | 19 ++++++++++---------
> > >  1 file changed, 10 insertions(+), 9 deletions(-)
> > 
> > Hi Khadija,
> > 
> > As Greg said this driver is not here any longer. This makes me think that
> > you
> > forgot at least two things...
> > 
> > 1) Please pull and rebase the staging tree every day while working on
> > patches
> > during this period of the Outreachy project. If you had done so, you would
> > have noticed that your patch cannot any more be applied.
> 
> This patch was sent long before the driver was deleted...  The patch was
> fine and would have been applied if the driver hadn't been removed.
> 
> regards,
> dan carpenter

I'm sorry I did not look at the day of the submission.
I took for granted that this patch had been sent after the contribution period 
start date, March 6th 2023.

Thanks Dan for making me notice this mistake.

Regards,

Fabio