From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6561B34556 for ; Wed, 6 Dec 2023 11:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="YWeG38iv" Received: from [100.122.216.38] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 166CD6607365; Wed, 6 Dec 2023 11:59:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701863967; bh=NQVRc6GiFEVTdKMxJaUtDzeg9fI0AYeC0jB8pgFpeUw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YWeG38ivXhQAXgqNhclFEjHJTFB+oP5vWkd1sKkLh0un3upmJX4Oiil5sHcYDYnVz HG3jXdqC1s67QcP8DLBd8wZrzwuqrybVTMdE4s5DEucJ0NiZxpDI3n0ChYOz0cxzWX GAOXcwFHwzW+ZM+J+ddpOYf/rVfs+J/kVzBI6m6kGvtOuv8EH/oj5TCXGgCZ9SAA8D FLze+zn4clZOOlxuTtb64Zk2826QeW2oFIhuv9QhtU2h8Ep8iEEnPXuDcxTXcbjISk s3JqoXrTsTQb2OEreh0iaT+wKxA7j9cr2QT6Nn9koR501kZiOZUWXN+Um0GljfjfIP YjMzlKRPzT6mg== Message-ID: <34558f91-4253-4a1f-997c-1c8b02786fcb@collabora.com> Date: Wed, 6 Dec 2023 12:59:24 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] videobuf2: core: Rename min_buffers_needed field to vb2_queue To: Dan Carpenter Cc: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com References: <20231206085608.33246-1-benjamin.gaignard@collabora.com> <20231206085608.33246-2-benjamin.gaignard@collabora.com> Content-Language: en-US From: Benjamin Gaignard In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 06/12/2023 à 10:54, Dan Carpenter a écrit : > On Wed, Dec 06, 2023 at 09:56:07AM +0100, Benjamin Gaignard wrote: >> Rename min_buffers_needed into min_queued_buffers and update >> the documentation about it. >> >> Signed-off-by: Benjamin Gaignard > [ snip ] > >> diff --git a/drivers/media/pci/zoran/zoran_driver.c b/drivers/media/pci/zoran/zoran_driver.c >> index fa672cc8bc67..2c91f75e8d79 100644 >> --- a/drivers/media/pci/zoran/zoran_driver.c >> +++ b/drivers/media/pci/zoran/zoran_driver.c >> @@ -749,9 +749,6 @@ static int zr_vb2_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsi >> >> zr->buf_in_reserve = 0; >> >> - if (*nbuffers < vq->min_buffers_needed) >> - *nbuffers = vq->min_buffers_needed; >> - >> if (*nplanes) { >> if (sizes[0] < size) >> return -EINVAL; > This was not mentioned in the commit message. And anyway, please do > that as a separate commit. It is a mistake, I don't want to change the drivers code. I will restore these lines in next version. Same for vdec driver below. Regards, Benjamin > > regards, > dan carpenter > > _______________________________________________ > Kernel mailing list -- kernel@mailman.collabora.com > To unsubscribe send an email to kernel-leave@mailman.collabora.com