From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8FEA2918 for ; Thu, 17 Aug 2023 21:02:11 +0000 (UTC) Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTP id WgHjqdAESEoVsWk8Bq9vvh; Thu, 17 Aug 2023 21:02:11 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id Wk8AqE0600LVOWk8AqhQ8V; Thu, 17 Aug 2023 21:02:10 +0000 X-Authority-Analysis: v=2.4 cv=BvCOfKb5 c=1 sm=1 tr=0 ts=64de8ad2 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=UttIx32zK-AA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=ag1SF4gXAAAA:8 a=pGLkceISAAAA:8 a=cm27Pg_UAAAA:8 a=VwQbUJbxAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=Yupwre4RP9_Eg_Bd0iYG:22 a=xmb-EsYY8bH0VWELuYED:22 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tARRQMv9SG0j8Ou7zFS+GX9Wit7Gyy3VndsgD0vYGeY=; b=jE9eQFREWs8M7/YqBeDH8qcAtC onRCpjN6/tuW6IjRfIYHir8zSTHUg8O8EDjl6fvXknSp5DM2orhwhP9Q81BrGqeHNHsIg950eCESS LZrk9pRe2fB6lrsN/f3553OTZ5/dqfu9tphZ7HI9jXAWQg9c4+Wok2JUi7bzNe9gCnOiZIs1SZlSx t+ZbXD37VZuzCEmMFtlVpcWYp4M2k4OTqfLvtzuDF/eQ1yY7XIv97wpMWztmZH+K3MlcO8sgrdlQW gDF+OT+EeymqW8Rzj3dcxEs2wuznkLsM3Dj1jnBJqKnDpMGpm6SigZotqxMI3JxfY2eazcOjt9uKX 2XQrE/hg==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:47346 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qWk89-001SRk-0L; Thu, 17 Aug 2023 16:02:09 -0500 Message-ID: <35dcbb0a-4dd6-39bf-3948-a069484b622c@embeddedor.com> Date: Thu, 17 Aug 2023 15:03:11 -0600 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] staging: rtl8192e: Annotate struct rtllib_txb with __counted_by Content-Language: en-US To: Kees Cook , Greg Kroah-Hartman Cc: Philipp Hortmann , linux-staging@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Tom Rix , Yogesh Hegde , Sumitra Sharma , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230817204523.never.034-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230817204523.never.034-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.linux.dev X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qWk89-001SRk-0L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:47346 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 18 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEakxvQ5b0c5h+RVzP9VkZ8r/ORsp1y0hjU6ub/+m1nOeIpRXA84HaVDQNFT7T2qS9BFYqu49jLCJlY/aGEH8XRw+hvmbU7Zhb7DrAHShixxebNhWZ+Z OFok3w5ohiURmli/S9XVeacw/93dPTviu9bu8ifDJulukplXB7cXa/JSPDNd/OUr1Q4I/bKrFfgJ0jZ4LXuibTD3bn3NCkq+XQointuufS1207XZTluSdNpI On 8/17/23 14:45, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct rtllib_txb. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Greg Kroah-Hartman > Cc: Philipp Hortmann > Cc: linux-staging@lists.linux.dev > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/staging/rtl8192e/rtllib.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index c5a692dfcd17..543d8671281d 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -818,7 +818,7 @@ struct rtllib_txb { > u16 reserved; > __le16 frag_size; > __le16 payload_size; > - struct sk_buff *fragments[]; > + struct sk_buff *fragments[] __counted_by(nr_frags); > }; > > #define MAX_SUBFRAME_COUNT 64