From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492A48527E; Wed, 20 Mar 2024 19:19:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710962355; cv=none; b=vBBKizBYAOLzTLKP6rtI3t51t3azUFTg0AGVrOIlqRLHrUxoPyTM1tiXoWoBgZJ/2nWmqtZtOZqbdPP6mfcYPPtvELrRq/uuXuoKdCLXmBLhSRk21DruS//E3FOaaALL75iy8R6/+Q1dSSLpVFdt7w7LaqbYtEKUUMtBDb1U21w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710962355; c=relaxed/simple; bh=iPJRmEumxajKjnt+YaiVZbpw05yONRfFEwzdYYywKw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qFiYWPajZRV3p2LpKQ++E+hDMdh83a2e1gNm52TC9K+Tr3HGdvHl4haFPGn+9HbwBeWphPUM101buV6khQKYLmVC3Q7q++EtGoatFzHpZnCk4DLlNnBHFBt+h7VJT8IyvtXUHvPW+Goef3cT9BM/S/ZyuNMj07PqsI89H5ccwt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ZX98izj6; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZX98izj6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710962354; x=1742498354; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iPJRmEumxajKjnt+YaiVZbpw05yONRfFEwzdYYywKw0=; b=ZX98izj6k+AQXa8WhtnWZHprXx88it2YHw9hv3Xn+u+MTUeuySzIJplS ++PsaaKX1k9RDsbWktRhjJltodw2c0RNF4pK34K3OABJ2LJwwCc/LyxxG 8tnP/LR18aki6g2H7yG+R8k5a/hfqgsBLagIgLfHiTbGc5L17Dq8bCtPE 0k7FCrfnB+prHBGE1ufpI0fuJT+sR7Tt+NHbLYwQisrfjVyCUeIDlHFhA tQXG8KBHnsnHrEDThkCd6aDfHfV8wKYWb04AjuNChMOWYfzmyMUHJLSzI 3Hbk/dDa2H6qH0TvaqQBUjht3TkEUHi4gjvcdN4Wh4NazVkccc5x2Fm3J g==; X-IronPort-AV: E=McAfee;i="6600,9927,11019"; a="17051001" X-IronPort-AV: E=Sophos;i="6.07,140,1708416000"; d="scan'208";a="17051001" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 12:19:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,140,1708416000"; d="scan'208";a="14322938" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.localnet) ([10.213.7.127]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 12:19:10 -0700 From: "Fabio M. De Francesco" To: Ayush Tiwari Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Subject: Re: [PATCH] staging: rtl8712: Change type of local variable Date: Wed, 20 Mar 2024 20:19:06 +0100 Message-ID: <3629769.BEx9A2HvPv@fdefranc-mobl3> Organization: intel In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday, 20 March 2024 19:53:50 CET Ayush Tiwari wrote: > Change data type of local variable blnPending from u8 to bool since it > only assumes 0 or 1 values. > > Signed-off-by: Ayush Tiwari > --- > drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c > b/drivers/staging/rtl8712/rtl8712_cmd.c index bb7db96ed821..32d9927981aa > 100644 > --- a/drivers/staging/rtl8712/rtl8712_cmd.c > +++ b/drivers/staging/rtl8712/rtl8712_cmd.c > @@ -284,7 +284,7 @@ int r8712_cmd_thread(void *context) > pcmd = cmd_hdl_filter(padapter, pcmd); > if (pcmd) { /* if pcmd != NULL, cmd will be handled by f/w */ > struct dvobj_priv *pdvobj = &padapter- >dvobjpriv; > - u8 blnPending = 0; > + bool blnPending = 0; bool types should take only 'true' and 'false' values. Therefore, if you change a type to 'bool' you should also convert the values it is assigned throughout its lifetime. Fabio P.S.: I just recalled that Dan has asked you to drop that 'b' prefix and do exactly what I wrote above. Are you going to ignore his comments? > u16 cmdcode = pcmd->cmdcode; > > pcmdpriv->cmd_issued_cnt++;