From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: r8188eu: Use completions for signaling start and end kthread
Date: Sat, 16 Oct 2021 21:32:57 +0200 [thread overview]
Message-ID: <3725568.Q3VL8gKjhB@localhost.localdomain> (raw)
In-Reply-To: <20211016192604.GV8429@kadam>
On Saturday, October 16, 2021 9:26:04 PM CEST Dan Carpenter wrote:
> Yeah, you're right. This is fine. It's a bit confusing how Arnd
> re-used complete to start the function.
>
> regards,
> dan carpenter
>
Thanks, Dan.
What still confuses me is why rtw_start_drv_threads() wants to be notified
that the kthread has started. Can you please answer this question?
Regards,
Fabio
next prev parent reply other threads:[~2021-10-16 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 9:10 [PATCH 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread() Fabio M. De Francesco
2021-10-16 9:10 ` [PATCH 1/3] staging: r8188eu: Use completions for signaling start and end kthread Fabio M. De Francesco
2021-10-16 19:26 ` Dan Carpenter
2021-10-16 19:32 ` Fabio M. De Francesco [this message]
2021-10-16 9:10 ` [PATCH 2/3] staging: r8188eu: Use completions for signaling enqueueing Fabio M. De Francesco
2021-10-16 9:10 ` [PATCH 3/3] staging: r8188eu: Remove redundant 'if' statement Fabio M. De Francesco
2021-10-16 9:59 ` Martin Kaiser
2021-10-16 15:27 ` [PATCH 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread() Phillip Potter
2021-10-16 17:54 ` Fabio M. De Francesco
2021-10-17 9:48 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3725568.Q3VL8gKjhB@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox