From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E80C2FAF for ; Thu, 19 Aug 2021 02:00:28 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id bq25so9211520ejb.11 for ; Wed, 18 Aug 2021 19:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IjykLTW5bWXHap6cNd2RLArWAcm8vCbGmYW9Q2CZ23E=; b=l2z+o/j1RL87n1mk8Ke/8+bO6OdMOYMBOHMHvfPK7hzoGXj+jMn56G/7Yw1o6Bsh4M oGTv45imw2fybnJ/7HiO5FQLOK4MTZCelmJJFMCZlKRfB7CKAeU37YICf3zTuStygHdl L0hC/YZgZaCSok53g4u+ty6GoOWmuYMRlmMpmCFKef74koWU2fTzJ6bI7yPbSSKIeGrT AgCqtfQV13uOz8hqhaZOGO87mwv52Xkru3CGBJpp9Mun4wM2pQ7qjd3RouOmrJRf7d7S Ps2D3ajLlZnWI8TVkWcAwRMyZhr0Zi6bUOfHJ7hC1Sne0RVAOy57HSnE1EDs1MigOHhf eMBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IjykLTW5bWXHap6cNd2RLArWAcm8vCbGmYW9Q2CZ23E=; b=I0a9JclUBI/KUqFHSDxhIBeFch2ExSWsNuiZ6CJkjMUwHJmSYel/WtM7xbUdmKdhGN 7Brc1U70RcSoUpj0WFnXIHzdLjaolc4nStlE1r5BwwInnFIPNBc3tJt0A+D1grwCbly5 es51AOCp9ikpuE7n+QKDlTj/AO6byBXPR9NUR9+PnHsN01y4yKDGeJRJk8cgkpRBj/SP 2HN6XEBo+PweVk2YPUcfm2CXUyElJA/R98oGVa5kAnhC2p8oSBTlCq5ZjBJbkpzrJd1I PZQaLmx4hehQkbRRxIb/lnJ31vf/asaDhHuhZmw5UoMUWLKW6Oen+svLg7Lt/M2jey3O WENQ== X-Gm-Message-State: AOAM530ED63e5OU5ysZ9fCdIjn2Izy07R1s+LC1+Xukp2rJcH2zp5cv+ pACtdLEyUZUTHcUsJ87tWgg= X-Google-Smtp-Source: ABdhPJx4PKwe+zyqeJFROuE20yp45TzzbKuGvmRHDE1nMO9B703n7+gldzNR0j8x/pHeFfYQ4G69zA== X-Received: by 2002:a17:906:c443:: with SMTP id ck3mr12545874ejb.195.1629338427326; Wed, 18 Aug 2021 19:00:27 -0700 (PDT) Received: from localhost.localdomain (host-79-22-109-211.retail.telecomitalia.it. [79.22.109.211]) by smtp.gmail.com with ESMTPSA id r16sm936755edt.15.2021.08.18.19.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 19:00:26 -0700 (PDT) From: "Fabio M. De Francesco" To: gregkh@linuxfoundation.org, Phillip Potter Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, martin@kaiser.cx, straube.linux@gmail.com, Larry.Finger@lwfinger.net Subject: Re: [PATCH 4/6] staging: r8188eu: remove empty function rtl8188eu_free_xmit_priv Date: Thu, 19 Aug 2021 04:00:25 +0200 Message-ID: <3783001.X7UpCbk0Mo@localhost.localdomain> In-Reply-To: <20210818234253.208271-5-phil@philpotter.co.uk> References: <20210818234253.208271-1-phil@philpotter.co.uk> <20210818234253.208271-5-phil@philpotter.co.uk> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday, August 19, 2021 1:42:51 AM CEST Phillip Potter wrote: > Remove empty function rtl8188eu_free_xmit_priv from hal/rtl8188eu_xmit.c > and its declaration from include/rtl8188e_xmit.h, as well as the one > place where it is stored in the free_xmit_priv function pointer of the > HalFunc struct inside padapter. This is safe, as the wrapper function > checks for NULL before calling this function via the function pointer. > > Signed-off-by: Phillip Potter > --- > drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 4 ---- > drivers/staging/r8188eu/hal/usb_halinit.c | 1 - > drivers/staging/r8188eu/include/rtl8188e_xmit.h | 1 - > 3 files changed, 6 deletions(-) > It looks good, so... Acked-by: Fabio M. De Francesco Thanks, Fabio