Re: [PATCH v2 0/2] staging: rtl8723bs: cleanup code and style

[Luka Gejak <luka.gejak@linux.dev>]

On March 30, 2026 8:46:37 PM GMT+02:00, Andrei Khomenkov <khomenkov@mailbox.org> wrote:
>This series of patches cleans up the rtl8723bs driver code to improve
>readability and better align with the Linux kernel coding style.
>The first patch simplifies boolean comparisons, while the second one
>performs general code cleanup.
>
>Link: https://lore.kernel.org/linux-staging/20260325110143.35466-1-khomenkov@mailbox.org/
>
>v2:
> - Split the single patch into a two-patch series to separate 
>   logical changes, as suggested by Luka Gejak.
> - Cleaned up additional boolean comparisons found using 'git grep'.
>
>Andrei Khomenkov (2):
>  staging: rtl8723bs: simplify boolean comparisons
>  staging: rtl8723bs: cleanup code style and parentheses
>
> drivers/staging/rtl8723bs/core/rtw_ap.c       |  2 +-
> drivers/staging/rtl8723bs/core/rtw_btcoex.c   |  4 +-
> .../staging/rtl8723bs/core/rtw_ieee80211.c    |  2 +-
> .../staging/rtl8723bs/core/rtw_ioctl_set.c    | 50 ++++++-------
> drivers/staging/rtl8723bs/core/rtw_mlme.c     | 18 ++---
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 16 ++---
> drivers/staging/rtl8723bs/core/rtw_recv.c     | 72 +++++++++----------
> drivers/staging/rtl8723bs/core/rtw_sta_mgt.c  |  2 +-
> .../staging/rtl8723bs/core/rtw_wlan_util.c    | 18 ++---
> drivers/staging/rtl8723bs/core/rtw_xmit.c     | 37 +++++-----
> drivers/staging/rtl8723bs/hal/hal_btcoex.c    | 10 +--
> drivers/staging/rtl8723bs/hal/hal_com.c       |  4 +-
> .../staging/rtl8723bs/hal/hal_com_phycfg.c    |  4 +-
> drivers/staging/rtl8723bs/hal/hal_intf.c      |  4 +-
> drivers/staging/rtl8723bs/hal/odm.c           |  8 +--
> .../staging/rtl8723bs/hal/odm_CfoTracking.c   |  2 +-
> drivers/staging/rtl8723bs/hal/odm_DIG.c       | 32 ++++-----
> drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c  |  2 +-
> drivers/staging/rtl8723bs/hal/rtl8723b_dm.c   | 10 +--
> .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 ++--
> .../staging/rtl8723bs/hal/rtl8723bs_recv.c    |  2 +-
> .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    |  6 +-
> drivers/staging/rtl8723bs/hal/sdio_halinit.c  |  6 +-
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 51 ++++++-------
> .../staging/rtl8723bs/os_dep/sdio_ops_linux.c |  4 +-
> drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 13 ++--
> 26 files changed, 194 insertions(+), 198 deletions(-)
>

Hi Andrei and Greg,
I am retracting my previous Reviewed-by tag.
As Greg pointed out, I reviewed this too hastily. This patch 
improperly mixes cosmetic style cleanups with functional logic changes
regarding the bitwise check_fwstate() evaluations. Furthermore, it 
introduces a syntax error (unbalanced parentheses) around line 782 in 
core/rtw_xmit.c that breaks the build.
Andrei, you will need to split this into a proper patch series:
1. Separate the functional bug fixes (the check_fwstate logic) from 
the pure style cleanups.
2. Group fixes of same kind by directory (e.g. core/, os_dep/) to keep
the patches manageable. For example simplify boolean comparisons in 
core directory.
Apologies for the noise.
Best regards,
Luka Gejak