From: Hans de Goede <hdegoede@redhat.com>
To: Sakirnth Nagarasa <sakirnth@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: ~lkcamp/patches@lists.sr.ht, helen.koike@collabora.com
Subject: Re: [PATCH] media: atomisp: move trailing statement to next line.
Date: Mon, 2 Sep 2024 12:10:41 +0200 [thread overview]
Message-ID: <389b81a7-a7be-48c0-adc0-40d313a38c5d@redhat.com> (raw)
In-Reply-To: <20240730084220.38204-1-sakirnth@gmail.com>
Hi,
On 7/30/24 10:42 AM, Sakirnth Nagarasa wrote:
> Fix checkpath error "ERROR: trailing statements should be on next line"
> in ia_css_fpn.host.c:46.
>
> Signed-off-by: Sakirnth Nagarasa <sakirnth@gmail.com>
Thank you for your patch(es).
I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
>
> Hello, this is my first patch to the kernel.
> ---
> .../atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> index 57b5e11e1..8ccfa99c6 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/fpn/fpn_1.0/ia_css_fpn.host.c
> @@ -43,7 +43,8 @@ ia_css_fpn_dump(
> const struct sh_css_isp_fpn_params *fpn,
> unsigned int level)
> {
> - if (!fpn) return;
> + if (!fpn)
> + return;
> ia_css_debug_dtrace(level, "Fixed Pattern Noise Reduction:\n");
> ia_css_debug_dtrace(level, "\t%-32s = %d\n",
> "fpn_shift", fpn->shift);
prev parent reply other threads:[~2024-09-02 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 8:42 [PATCH] media: atomisp: move trailing statement to next line Sakirnth Nagarasa
2024-09-02 10:10 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=389b81a7-a7be-48c0-adc0-40d313a38c5d@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sakirnth@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox