From: Hans de Goede <hdegoede@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Cc: outreachy@lists.linux.dev, julia.lawall@inria.fr,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
andy@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com
Subject: Re: [PATCH v2 1/3] staging: media: Remove duplicate NULL tests on a value in pci
Date: Thu, 3 Apr 2025 16:19:46 +0200 [thread overview]
Message-ID: <3beaf600-1670-44de-a782-6e34010061e3@redhat.com> (raw)
In-Reply-To: <2025040320-fraction-bagel-ea64@gregkh>
Hi,
On 3-Apr-25 3:54 PM, Greg KH wrote:
> On Thu, Apr 03, 2025 at 02:26:41PM +0100, Abraham Samuel Adekunle wrote:
>> When a value has been tested for NULL in an expression, a
>> second NULL test on the same value in another expression
>> is unnecessary when the value has not been assigned NULL.
>>
>> Remove unnecessary duplicate NULL tests on the same value that
>> has previously been NULL tested.
>>
>> Found by Coccinelle
>>
>> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
>> ---
>> drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
>
> I can't take any drivers/staging/media/ changes for outreachy
> applications, sorry. That should have been in the instructions
> somewhere.
I don't know if this helps wrt outreachy but I can pick
up this atomisp (and I plan to do so).
Regards,
Hans
next prev parent reply other threads:[~2025-04-03 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 13:26 [PATCH v2 0/3] Unnecessary code cleanup patches Abraham Samuel Adekunle
2025-04-03 13:26 ` [PATCH v2 1/3] staging: media: Remove duplicate NULL tests on a value in pci Abraham Samuel Adekunle
2025-04-03 13:31 ` Andy Shevchenko
2025-04-03 23:32 ` Samuel Abraham
2025-04-03 13:54 ` Greg KH
2025-04-03 14:19 ` Hans de Goede [this message]
2025-05-01 14:16 ` Hans de Goede
2025-04-03 13:26 ` [PATCH v2 2/3] staging: media: Remove duplicated NULL tests on a value in av7110 Abraham Samuel Adekunle
2025-04-03 13:35 ` Andy Shevchenko
2025-04-03 13:26 ` [PATCH v2 3/3] staging: rtl8723bs: Prevent duplicate NULL tests on a value Abraham Samuel Adekunle
2025-04-03 13:39 ` Andy Shevchenko
2025-04-03 23:34 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3beaf600-1670-44de-a782-6e34010061e3@redhat.com \
--to=hdegoede@redhat.com \
--cc=abrahamadekunle50@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox