From: Eric Florin <ericflorin@google.com>
To: teddy.wang@siliconmotion.com
Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Eric Florin <ericflorin@google.com>
Subject: [PATCH 7/9] staging: sm750fb: rename `hw_sm750_setColReg`
Date: Sun, 18 May 2025 19:04:50 -0700 [thread overview]
Message-ID: <3d4bb87742eee4a6792bbdae893256f621ffffe6.1747619816.git.ericflorin@google.com> (raw)
In-Reply-To: <cover.1747619816.git.ericflorin@google.com>
Rename `hw_sm750_setColReg` to `hw_sm750_set_col_reg` to conform with
kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hw_sm750_setColReg>
Signed-off-by: Eric Florin <ericflorin@google.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 4 ++--
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 5f4b0064cf92..935c7b1a0fa4 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -545,7 +545,7 @@ static int lynxfb_ops_setcolreg(unsigned int regno,
red >>= 8;
green >>= 8;
blue >>= 8;
- ret = hw_sm750_setColReg(crtc, regno, red, green, blue);
+ ret = hw_sm750_set_col_reg(crtc, regno, red, green, blue);
goto exit;
}
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index db80dd295658..a70f51d08dd2 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -208,8 +208,8 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
struct fb_var_screeninfo *var,
struct fb_fix_screeninfo *fix);
-int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index,
- ushort red, ushort green, ushort blue);
+int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index,
+ ushort red, ushort green, ushort blue);
int hw_sm750_setBLANK(struct lynxfb_output *output, int blank);
int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index d3f218cb20f5..04a0f9218eb8 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -370,8 +370,8 @@ int hw_sm750_crtc_set_mode(struct lynxfb_crtc *crtc,
return ret;
}
-int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index, ushort red,
- ushort green, ushort blue)
+int hw_sm750_set_col_reg(struct lynxfb_crtc *crtc, ushort index, ushort red,
+ ushort green, ushort blue)
{
static unsigned int add[] = { PANEL_PALETTE_RAM, CRT_PALETTE_RAM };
--
2.49.0.1112.g889b7c5bd8-goog
next prev parent reply other threads:[~2025-05-19 2:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 2:04 [PATCH 0/9] staging: sm750fb: Rename function headers in `sm750.h` Eric Florin
2025-05-19 2:04 ` [PATCH 1/9] staging: sm750fb: rename `hw_sm750_initAccel` Eric Florin
2025-05-19 2:04 ` [PATCH 2/9] staging: sm750fb: rename `hw_sm750_deWait` Eric Florin
2025-05-19 2:04 ` [PATCH 3/9] staging: sm750fb: rename `hw_sm750le_deWait` Eric Florin
2025-05-19 2:04 ` [PATCH 4/9] staging: sm750fb: rename `hw_sm750_output_setMode` Eric Florin
2025-05-19 2:04 ` [PATCH 5/9] staging: sm750fb: rename `hw_sm750_crtc_checkMode` Eric Florin
2025-05-19 2:04 ` [PATCH 6/9] staging: sm750fb: rename `hw_sm750_crtc_setMode` Eric Florin
2025-05-19 2:04 ` Eric Florin [this message]
2025-05-19 2:04 ` [PATCH 8/9] staging: sm750fb: rename `hw_sm750_setBLANK` Eric Florin
2025-05-19 2:04 ` [PATCH 9/9] staging: sm750fb: rename `hw_sm750le_setBLANK` Eric Florin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d4bb87742eee4a6792bbdae893256f621ffffe6.1747619816.git.ericflorin@google.com \
--to=ericflorin@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox