From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 985E02F744B for ; Mon, 10 Nov 2025 23:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762817871; cv=none; b=LsXXsazwMnOx+6HKuceAOs6L1wmuL6PR/kLiShmCNFl0ac+zBkd7Xaq/7dEyrYlFs3izgq84CzoVB0EXItYSIDk+tm52P/WJfMw0UhxVYpDf77z6grKamgjgMh+ZiAy5R3LnaDoq90e49S00GkDH2aH52q4gGZSuoKujDG9bAzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762817871; c=relaxed/simple; bh=odPTQHqCk/AknyMQCUhv0A0QcmH6YIldSa1T8WY4Ets=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F5JZzhuW2tKHrw9eSdAyBpPGg2Mn/Sn0+0l/oa6Z6SiRpdMJth8O6bfi5cHdDYiy+tob37CR+Bc2t2jgzXTgSAUK6HoKYWJ/kEprD4ltcFNlrK826YG/jTBGWoQyUWX+sHhZ4VF7Cwc1+P6J/akTIpuFllIPTOLoQyELTsRoRJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=U0xyIRec; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="U0xyIRec" Message-ID: <3eb5379f-c7ad-4aea-ab9a-20e07b7f34d0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1762817866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N5NdZ3Il1D+l8lwQLcK5dXwNIadjasDY9t8ilnV/mV0=; b=U0xyIRecUBR+iYd+jFcmevJu/4H+A2bbNJnN96yfE0hlgn9ZMrH3LxAIKYqZS4s3cJ1uvm +7WK+gk43pd/VuQQ8rDReqm1AlKlWm8GBWmK3v11GgPPZIdbI1RU8LPuoyCqW5EbUBDj5d 3Ou4TSlLX99wMRUdq/vNAC0vrqSI3Ow= Date: Mon, 10 Nov 2025 23:37:33 +0000 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v1 19/23] ptp: ocp: Switch to use %ptSp To: Andy Shevchenko , Corey Minyard , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Dr. David Alan Gilbert" , Alex Deucher , Thomas Zimmermann , Dmitry Baryshkov , Rob Clark , Matthew Brost , Hans Verkuil , Laurent Pinchart , Ulf Hansson , Vitaly Lifshits , Manivannan Sadhasivam , Niklas Cassel , Calvin Owens , Sagi Maimon , "Martin K. Petersen" , Karan Tilak Kumar , Casey Schaufler , Steven Rostedt , Petr Mladek , Max Kellermann , Takashi Iwai , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-staging@lists.linux.dev, ceph-devel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-sound@vger.kernel.org Cc: Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Sumit Semwal , Gustavo Padovan , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Konrad Dybcio , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Mauro Carvalho Chehab , Vladimir Oltean , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tony Nguyen , Przemek Kitszel , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Rodolfo Giometti , Jonathan Lemon , Richard Cochran , Stefan Haberland , Jan Hoeppner , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Satish Kharat , Sesidhar Baddela , "James E.J. Bottomley" , Greg Kroah-Hartman , Xiubo Li , Ilya Dryomov , Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Jaroslav Kysela , Takashi Iwai References: <20251110184727.666591-1-andriy.shevchenko@linux.intel.com> <20251110184727.666591-20-andriy.shevchenko@linux.intel.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20251110184727.666591-20-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 10/11/2025 18:40, Andy Shevchenko wrote: > Use %ptSp instead of open coded variants to print content of > struct timespec64 in human readable format. > > While at it, fix wrong use of %ptT against struct timespec64. > It's kinda lucky that it worked just because the first member > there 64-bit and it's of time64_t type. Now with %ptS it may > be used correctly. > > Signed-off-by: Andy Shevchenko > --- > drivers/ptp/ptp_ocp.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c > index a5c363252986..a0bb8d3045d2 100644 > --- a/drivers/ptp/ptp_ocp.c > +++ b/drivers/ptp/ptp_ocp.c > @@ -3261,7 +3261,7 @@ signal_show(struct device *dev, struct device_attribute *attr, char *buf) > signal->duty, signal->phase, signal->polarity); > > ts = ktime_to_timespec64(signal->start); > - count += sysfs_emit_at(buf, count, " %ptT TAI\n", &ts); > + count += sysfs_emit_at(buf, count, " %ptS TAI\n", &ts); > > return count; > } > @@ -4287,11 +4287,9 @@ ptp_ocp_summary_show(struct seq_file *s, void *data) > ns += (s64)bp->utc_tai_offset * NSEC_PER_SEC; > sys_ts = ns_to_timespec64(ns); > > - seq_printf(s, "%7s: %lld.%ld == %ptT TAI\n", "PHC", > - ts.tv_sec, ts.tv_nsec, &ts); > - seq_printf(s, "%7s: %lld.%ld == %ptT UTC offset %d\n", "SYS", > - sys_ts.tv_sec, sys_ts.tv_nsec, &sys_ts, > - bp->utc_tai_offset); > + seq_printf(s, "%7s: %ptSp == %ptS TAI\n", "PHC", &ts, &ts); > + seq_printf(s, "%7s: %ptSp == %ptS UTC offset %d\n", "SYS", > + &sys_ts, &sys_ts, bp->utc_tai_offset); > seq_printf(s, "%7s: PHC:SYS offset: %lld window: %lld\n", "", > timespec64_to_ns(&ts) - ns, > post_ns - pre_ns); > @@ -4499,9 +4497,8 @@ ptp_ocp_phc_info(struct ptp_ocp *bp) > ptp_clock_index(bp->ptp)); > > if (!ptp_ocp_gettimex(&bp->ptp_info, &ts, NULL)) > - dev_info(&bp->pdev->dev, "Time: %lld.%ld, %s\n", > - ts.tv_sec, ts.tv_nsec, > - bp->sync ? "in-sync" : "UNSYNCED"); > + dev_info(&bp->pdev->dev, "Time: %ptSp, %s\n", > + &ts, bp->sync ? "in-sync" : "UNSYNCED"); > } > > static void Acked-by: Vadim Fedorenko