From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Gary Rookard <garyrookard@fastmail.org>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series
Date: Tue, 21 Nov 2023 22:39:48 +0100 [thread overview]
Message-ID: <4004f37e-66f8-4ba3-bfa4-41235e979043@gmail.com> (raw)
In-Reply-To: <20231121181435.9337-1-garyrookard@fastmail.org>
On 11/21/23 19:14, Gary Rookard wrote:
> Hi,
>
> This patch series renames 5 different variables from
> Pascal/CamelCase to snake case.
>
> Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
> Driver/module rtl8291e compiles.
>
> Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate
> Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate
> Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps
> Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine
> Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m
>
> Regards,
> Gary
>
Hi Gary,
this patch series needs to be a V2 with change history.
The next patch series you are going to send is V3.
The cover letter of your patch series seems to be hand made. You can use
git to do this.
I am using this command to do this:
git format-patch -o ~/Documents/kernel/patches/ --cover-letter -n
--thread=shallow --to="Greg Kroah-Hartman
<gregkh@linuxfoundation.org>,linux-staging@lists.linux.dev,linux-kernel@vger.kernel.org"
7b88c62d3cc5c3fb670b5448c7381c7c099b3518^..HEAD
There are now 31 patches pending for this driver. May be it is a good
idea to wait until those are accepted or rejected. May be this is
happening on Thursday morning. Or you apply the patches before you put
yours on top:
https://lore.kernel.org/linux-staging/c464f4a8-753b-417c-97bb-7aa29ab5bf59@gmail.com/T/#t
https://lore.kernel.org/linux-staging/cover.1700296319.git.philipp.g.hortmann@gmail.com/T/#t
https://lore.kernel.org/linux-staging/d911d509-8677-444c-ad7f-92dd141e8e1e@suswa.mountain/T/#t
In case of question feel free to write to me.
Bye Philipp
next prev parent reply other threads:[~2023-11-21 21:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 18:14 [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Gary Rookard
2023-11-21 18:14 ` [PATCH 1/5] staging: rtl8192e; renamed variable HTMcsToDataRate Gary Rookard
2023-11-21 18:14 ` [PATCH 2/5] staging: rtl8192e: renamed variable TXCountToDataRate Gary Rookard
2023-11-21 18:14 ` [PATCH 3/5] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Gary Rookard
2023-11-21 18:14 ` [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTPeerDetermine Gary Rookard
2023-11-21 18:14 ` [PATCH 5/5] staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M Gary Rookard
2023-11-21 21:39 ` Philipp Hortmann [this message]
2023-11-23 12:44 ` [PATCH 0/5] staging: rtl8192e: renaming of 5 different variables patch series Greg KH
-- strict thread matches above, loose matches on Subject: below --
2023-11-21 18:09 Gary Rookard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4004f37e-66f8-4ba3-bfa4-41235e979043@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=garyrookard@fastmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox