From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64CD85644; Wed, 20 Mar 2024 19:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710964273; cv=none; b=tICVju9c85YhbNc6UhPoidRcg82YuFkfSJ2JxoiSkjbLwdNDVTQz2OthvZMiunU3AQR+1ZU1KtkBAWp+wxxnVVe68TbXWo831YKnWD23D4T13j15YNNczAVJ0EpkNkBigN4VdbxLCTnZjlbQGubXuDVp0DyfPWR9hV8iVUlh5c0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710964273; c=relaxed/simple; bh=EpwmDWMEvj+bTYnIg0y28dqQH8LEVqmqsBX939rabos=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sm8jDnpbQD3o5LUGGkd3VP7SAG18gHjv56m96mKqASi8f3k6RU1SticXf/Tn+L9sb03qkIaEBvYJDW7kC2MwCGOT0XY2J/djJ6OD2rrUGkekWG+65sQHVBIPmQ6elMarEPPLJiOVkbODswcKJPaRK1kz2yaZvoZQ2bhgpvaWlf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=R8Qi/WVv; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="R8Qi/WVv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710964271; x=1742500271; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EpwmDWMEvj+bTYnIg0y28dqQH8LEVqmqsBX939rabos=; b=R8Qi/WVv0w+1YwWlw8fRTLySPAi3rWY3VjlhSo/ONAZwsKYzlnhIf7ar IbDXSqDD3jbdnAKQ/XlujCH9SA/DNRXi4AiZJtlfKzEkbWVINQm3c/7W9 128eJjYEX22g3EFkgR4Ji8Iu3VSdfip+VsvWm+T3xwgMQ099kar+NxRe3 lnyVjliPrNYRhx/9J0ns5BdramrTdq0mBtU+1RT/8FA2J2zPWwFQoUzKq Q5riVRV23IrX8fLqdXbNaZwmhQd+wNSmXuGpVz2ZpSJggeXHS6RX0qlZ1 az+0VBtM1qD++ZeF6G/UTO9VV1cxb0ByO1vODwC0ZtPt68LExAVVIXksa w==; X-IronPort-AV: E=McAfee;i="6600,9927,11019"; a="16652614" X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="16652614" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 12:50:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,141,1708416000"; d="scan'208";a="14655562" Received: from fdefranc-mobl3.ger.corp.intel.com (HELO fdefranc-mobl3.localnet) ([10.213.7.127]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2024 12:50:44 -0700 From: "Fabio M. De Francesco" To: Ayush Tiwari Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev Subject: Re: [PATCH v2 0/3] Trivial code cleanup patches Date: Wed, 20 Mar 2024 20:50:40 +0100 Message-ID: <4105521.oiGErgHkdL@fdefranc-mobl3> Organization: intel In-Reply-To: <6485785.DvuYhMxLoT@fdefranc-mobl3> References: <6485785.DvuYhMxLoT@fdefranc-mobl3> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Tuesday, 19 March 2024 07:04:34 CET Fabio M. De Francesco wrote: > On Monday, 18 March 2024 20:54:09 CET Ayush Tiwari wrote: > > Address different kinds of checkpatch complains for the rtl8712 module > > to ensure adherence to coding style guidelines. > > > > Changes in v2: Checked any possible reuse of backup_PMKID_list > > manually and rebuilt, No you didn't do what you are saying. > rebooted the kernel and loaded the driver > > with modprobe. > > You have not made any changes to any of the three patches in this series. > No changes in commit messages and no changes in code. Am I missing > something? > > So why did you submit a v2 of this series? > > Fabio Julia commented on patch 1/3. You should either reply that everything is correct (if it is) or fix your patch. Please don't send new versions that don't change anything and don't ignore comments (mine included). > > Ayush Tiwari (3): > > staging: rtl8712: rename backupPMKIDList to backup_PMKID_list This patch introduces errors. You haven't compiled this module, otherwise you would have noticed that. Always compile your changes (preferably with CONFIG_WERROR set). Please read the output of git-grep: [fabio@linux]$ git grep backupPMKIDList drivers/staging/rtl8712 drivers/staging/rtl8712/mlme_linux.c: static struct RT_PMKID_LIST backupPMKIDList[NUM_PMKID_CACHE]; drivers/staging/rtl8712/mlme_linux.c: memcpy(&backupPMKIDList[0], drivers/staging/rtl8712/mlme_linux.c: &backupPMKIDList[0], Can you see how patch 1/3 introduces errors? Fabio > > staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index > > staging: rtl8712: rename backupTKIPCountermeasure to > > > > backup_TKIP_countermeasure > > > > drivers/staging/rtl8712/mlme_linux.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-)