Re: [PATCH] staging: rtl8712: remove trailing whitespace

[Philipp Hortmann <philipp.g.hortmann@gmail.com>]

On 7/30/24 08:37, Felix Yan wrote:
> Fix the following checkpatch.pl error:
> 
> ERROR: trailing whitespace
> 
> Signed-off-by: Felix Yan <felixonmars@archlinux.org>
> ---
>   drivers/staging/rtl8712/rtl871x_cmd.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_cmd.h b/drivers/staging/rtl8712/rtl871x_cmd.h
> index 2613b3c2acfc..268844af57f0 100644
> --- a/drivers/staging/rtl8712/rtl871x_cmd.h
> +++ b/drivers/staging/rtl8712/rtl871x_cmd.h
> @@ -736,7 +736,7 @@ void r8712_getbbrfreg_cmdrsp_callback(struct _adapter *padapter, struct cmd_obj
>   void r8712_readtssi_cmdrsp_callback(struct _adapter *padapter, struct cmd_obj *pcmd);
>   void r8712_setstaKey_cmdrsp_callback(struct _adapter  *padapter, struct cmd_obj *pcmd);
>   void r8712_setassocsta_cmdrsp_callback(struct _adapter  *padapter, struct cmd_obj *pcmd);
> -void r8712_disconnectCtrlEx_cmd(struct _adapter *adapter, u32 enableDrvCtrl, u32 tryPktCnt,
> +void r8712_disconnectCtrlEx_cmd(struct _adapter *adapter, u32 enableDrvCtrl, u32 tryPktCnt,
>   				u32 tryPktInterval, u32 firstStageTO);
>   
>   struct _cmd_callback {


Hi Felix,

Please make your "Subject" line more unique. Consider that we may end up 
with having dozen of commits like yours, all of them referring to 
different removals and all without the necessary information to tell 
what they differ in (except the driver/subsystem). So it would help if 
you add the changed file or function to make it more unique.

Please do not add extra empty lines in the description when not 
required. Consider that we have a lot of commits and it is most wanted 
that the description is short.

It is not required to add the name of the tool who found this, but it 
can be named. Much more important is a good description why this change 
makes sense...
For example:
... to shorten code.
... to improve readability.
...

I cannot apply your patch:
Applying: staging: rtl8712: remove trailing whitespace
error: patch failed: drivers/staging/rtl8712/rtl871x_cmd.h:736
error: drivers/staging/rtl8712/rtl871x_cmd.h: patch does not apply
Patch failed at 0001 staging: rtl8712: remove trailing whitespace

Are you using the right git repo?

git remote show origin
* remote origin
   Fetch URL: 
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
...
git branch -a
my branch: staging-testing

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

In case of questions feel free to contact me directly.

Thanks for your support.

Bye Philipp