From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F8172 for ; Mon, 2 Aug 2021 15:21:17 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id z11so2555119edb.11 for ; Mon, 02 Aug 2021 08:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IVqYYLjGOPKQife1ID3vUeLHeieycL8YR2lT+WrDkFI=; b=jXk2OP6NdkifNBX3E6RH9oS7ZXLx9+q+2q3xOOoj9K0IbOnbA4gvu+6Ib73oCOE2+4 co5XXYMkEK19URYAdQhG7BoLRgmfdl3EqO/zsJKs6M93XViQlJEcbzs247qmKig0vpeL 9p1Y5uwjjUOMWojKQLM4KpjugvMhZ1USBTL5m15wpNWenIj1KnGnpgL+SQZ8mVQI6cJW qZPkDIVuBPW7TPbQdVZJxQFoKq+fGtNGpqYJ68yHhheWv2+PGoAmoDIy+OxHlAjz1pZx Twf85Orbu8o8ZyYKrOLZ14eV/56wI3RiHhubWy10tO536HWR4hUv2Zri1IsOepYCRDtN doug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IVqYYLjGOPKQife1ID3vUeLHeieycL8YR2lT+WrDkFI=; b=MioQ2CYIYAf2f3hLmPADXLo8KIK427iYp49isbud9Zd+ANWQ5z1BQgXXQ+8soszFsJ V9RMxl/l+zGucCbawHzWjUzSMZzlZvvgKTOAlkWTM1YL/owoYyP6plPyq8q66jg7Yh9m NSNXkKz6T5vc7Rv/9YJ2LzPYsfOFDAvrwrqmBmXo/zbjAv2qMCwRIAzFY6qaDOBUE98j L+P5fM4tIdScK1mo7DnI2HOg2dDeWmJftZJSFjR2PM71B+/Z5yHwUYEZUSNDhiLn6QXK 47pbMkTWEucLO0DS4ROae6kdkqTmsu7SMBE0ObQQgtr67Ky8+3tFhzDx1D28erQgkGSk xUxA== X-Gm-Message-State: AOAM531WUDgW2rVAyELEJpfCF6nSDCuUYM02B+IGDL8Fi274LP7ii10K j6PMQYfJVKX+aA5s1HpU6Zw= X-Google-Smtp-Source: ABdhPJyRxHIXCVK8ir4zjMfG4mHt+mmLmFPcDMV7K5upkC7HV6/82qpwTeO8YU8l+t2p3GXXsU/8Ag== X-Received: by 2002:a05:6402:1778:: with SMTP id da24mr20117959edb.385.1627917675986; Mon, 02 Aug 2021 08:21:15 -0700 (PDT) Received: from localhost.localdomain (host-82-51-42-96.retail.telecomitalia.it. [82.51.42.96]) by smtp.gmail.com with ESMTPSA id oz27sm4703948ejb.90.2021.08.02.08.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 08:21:15 -0700 (PDT) From: "Fabio M. De Francesco" To: Dan Carpenter Cc: Greg Kroah-Hartman , Larry Finger , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: Fix different base types in assignments and parameters Date: Mon, 02 Aug 2021 17:21:14 +0200 Message-ID: <4462633.k6rmAWbitH@localhost.localdomain> In-Reply-To: <2081658.ULrIQvW0dQ@localhost.localdomain> References: <20210730181452.23062-1-fmdefrancesco@gmail.com> <20210802140505.GZ1931@kadam> <2081658.ULrIQvW0dQ@localhost.localdomain> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday, August 2, 2021 4:26:33 PM CEST Fabio M. De Francesco wrote: > On Monday, August 2, 2021 4:05:05 PM CEST Dan Carpenter wrote: > > On Fri, Jul 30, 2021 at 08:14:52PM +0200, Fabio M. De Francesco wrote: > > > Fix sparse warnings of different base types in assignments > > > and in passing function parameters. > > > > [...] > > > > > > + union { > > > + unsigned int f0; > > > + unsigned char f1[IPX_NODE_LEN]; > > > > What is going on here?? Why is f1 six bytes? > > Please look at the third parameter of the latest memcpy() in this function. > No, I'm wrong here. I must have exchanged in my mind the latest and the memcpy() before the latest. So I see a '6' in the wrong memcpy(). I'll fix it ASAP. Thanks, Fabio