public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Gary Rookard <garyrookard@fastmail.org>, gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables
Date: Fri, 8 Dec 2023 18:49:38 +0100	[thread overview]
Message-ID: <493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com> (raw)
In-Reply-To: <20231208015536.21013-1-garyrookard@fastmail.org>

On 12/8/23 02:55, Gary Rookard wrote:
> Hi,
> 
> This patch series renames 5 different variables with the checkpatch
> coding style issue, Avoid CamelCase.
> 
> Patch 1/5) renamed variable bCurShortGI40MHz
> Patch 2/5) renamed variable bcurShortGI20MHz
> Patch 3/5) renamed variable CCKOFDMRate
> Patch 4/5) renamed variable HTIOTActIsCCDFsync
> Patch 5/5) renamed variable IOTPeer
> 
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
> 
> 
> Gary Rookard (5):
>    staging: rtl8192e: renamed variable bCurShortGI40MHz
>    staging: rtl8192e: renamed variable bCurShortGI20MHz
>    staging: rtl8192e: renamed variable CCKOFDMRate
>    staging: rtl8192e: renamed variable HTIOTActIsCCDFsync
>    staging: rtl8192e: renamed variable IOTPeer
> 
>   .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  4 +-
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    | 22 +++----
>   drivers/staging/rtl8192e/rtl819x_HT.h         |  6 +-
>   drivers/staging/rtl8192e/rtl819x_HTProc.c     | 58 +++++++++----------
>   drivers/staging/rtl8192e/rtllib_tx.c          |  4 +-
>   5 files changed, 47 insertions(+), 47 deletions(-)
> 


Please use present-tense as outlined here:
https://kernelnewbies.org/PatchPhilosophy
So rename instead of renamed

Please use a more unique Subject for your coverletter.
It often cannot cover everything. But more unique is better.



Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

  parent reply	other threads:[~2023-12-08 17:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  1:55 [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-08  1:55 ` [PATCH 1/5] staging: rtl8192e: renamed variable bCurShortGI40MHz Gary Rookard
2023-12-08  1:55 ` [PATCH 2/5] staging: rtl8192e: renamed variable bCurShortGI20MHz Gary Rookard
2023-12-08  1:55 ` [PATCH 3/5] staging: rtl8192e: renamed variable CCKOFDMRate Gary Rookard
2023-12-08  1:55 ` [PATCH 4/5] staging: rtl8192e: renamed variable HTIOTActIsCCDFsync Gary Rookard
2023-12-08 17:49 ` Philipp Hortmann [this message]
2023-12-08 21:56   ` [PATCH 0/5] staging: rtl8192e: patch series renames (5) different variables Gary Rookard
2023-12-09 17:16     ` Philipp Hortmann
2023-12-09  0:41   ` Gary Rookard
  -- strict thread matches above, loose matches on Subject: below --
2023-12-05 23:16 Gary Rookard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493fe783-46b3-4da7-b0d9-01425e6adf2a@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=garyrookard@fastmail.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox