From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991242FAE for ; Sun, 26 Sep 2021 08:13:51 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id eg28so55319701edb.1 for ; Sun, 26 Sep 2021 01:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=U/dRGcXIN9RWdls4uHT+lAIP/aPDFXHvQ1puoWeWARU=; b=qiMOlXWa6K1XdtRkco69+WXViEwbAk3FcFbQ/7de5QoqteWdFLhQSGqvlaXJkO50K5 sZozrkqwO9bXV6TJMGxsPwyLQJQkyvKvohJHwReTYzXtVjMCqqAfeq38U9AlGFGmL03w Df6Bk/fApBxn4jP7QlLFVjfdk5KDaH3IN5Sryn/NlSbYrSUsESM4peIgD05cWf3efSOo vpOVbBlaSliQTgHwLcbgOxkovevREmf+uI2KNaAyOiVTI9bBfQVvvmwtaQP0zFkHX71a c/kRS/J7ttrmFzqk97PklOKriT0hQg6zie7CSmr8YTOYGmJSzwWHsWkuqaip0NBR0GXc 0cgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U/dRGcXIN9RWdls4uHT+lAIP/aPDFXHvQ1puoWeWARU=; b=6g2HjcKZCuXSRL8N50dHnMjy3jlQr9HlCW3aGwsPPgH0In+q5HEyJiH0ZLjaLZmske ZormLK6Yzqb268j3T6qQiR2SvLKlulveHhIQrGslLuqxvZ8CFrCp3spxN40TGjeepU69 +8hIRSZjxC6PRVM14Oe1P3BzzhYsqEofbpuIxzEmoryUhuYWZs92TmUVjq9ByQpeqe8h E+jypuNlIYo6EARKk0LmVninBzLFAjmBb+45wZ3x4R8YVKg3AFOi839MUhYR0k5DP0AR +yfmJGvwK1SUJOLdzXXXSkdLuEc9Z/TXgVoPhXowk/0I+R7oOW4zttGmMCkn13ftMXfT K1jQ== X-Gm-Message-State: AOAM5333fCAkkOlViDwKSLDw8jo419k1F+fJLDAFz1VAx41jmgFitL5H QX57plJi22UzYtjL9PInEUc= X-Google-Smtp-Source: ABdhPJwVQApvSnJOEY2ByzXTtEtmNni7Uz30xqyZp6XI+WQOtx/jPf7+alUc4VR1GzaaSzbzKSDTSA== X-Received: by 2002:a50:9b06:: with SMTP id o6mr16260752edi.284.1632644029808; Sun, 26 Sep 2021 01:13:49 -0700 (PDT) Received: from localhost.localdomain (host-212-171-30-160.pool212171.interbusiness.it. [212.171.30.160]) by smtp.gmail.com with ESMTPSA id q6sm7046793eju.45.2021.09.26.01.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Sep 2021 01:13:49 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Michael Estner Cc: michaelestner@web.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Remove uneccessary parantheas Date: Sun, 26 Sep 2021 10:13:46 +0200 Message-ID: <4951952.txS7XvjiL2@localhost.localdomain> In-Reply-To: <20210925192018.6745-1-michaelestner@web.de> References: <20210925192018.6745-1-michaelestner@web.de> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Saturday, September 25, 2021 9:20:15 PM CEST Michael Estner wrote: > Fix to be conform with the checkpatch style requirements Greg K-H's "friendly patch bot" has already been triggered and sent you a message. Usually, according to Greg's style :), this is all you get and then you are left alone to figure out what you did wrong and eventually submit a new version. However, as this is your very first patch, I would like to give you some additional information that may help you. 1) Where is the name of the driver your fixing? You must place it in the subject and its position and formatting must comply with this subsystem rules. Please, read other patches for staging among those that have already been accepted. 2) What language are you using in the subject? "Remove uneccessary parantheas" has no meaning in English. Typos can happen, but you have not made any typos: your "Subject line" is a completely incomprehensible sequence of characters. :) 3) "Fix to be conform[]" (sigh). Fix what? Changelogs (or "Commits messages") must be self-contained, so write them like if you expected that the Reviewers immediately forget what they read in the "Subject" line. While you are at it, please also correct grammar. (Finally, it is the Linux kernel maintainers and developers who have "style requirements", listed in the "Linux kernel coding style" document, instead checkpatch.pl has no requirements (it just checks for style violations)). Thanks, Fabio > Signed-off-by: Michael Estner > ---