From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
arnd@arndb.de
Subject: Re: [PATCH 05/11] staging: gpib: Remove GPIB_DEBUG reference and update messaging
Date: Mon, 4 Nov 2024 11:43:32 +0300 [thread overview]
Message-ID: <4c4aba7e-c873-4a93-9311-bd2e2bbcd8e8@stanley.mountain> (raw)
In-Reply-To: <20241103212617.13076-6-dpenkler@gmail.com>
On Sun, Nov 03, 2024 at 10:26:11PM +0100, Dave Penkler wrote:
> Change pr_alert to dev_alert
>
> Signed-off-by: Dave Penkler <dpenkler@gmail.com>
> ---
> .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 69 +++++++++----------
> 1 file changed, 34 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> index 4c580137043f..796c3a5be545 100644
> --- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> +++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
> @@ -68,11 +68,8 @@ MODULE_DEVICE_TABLE(usb, skel_table);
> * At module loading: modprobe lpvo_usb_gpib debug={0,1,2}
> * On the fly: echo {0,1,2} > /sys/modules/lpvo_usb_gpib/parameters/debug
> */
> -#ifdef GPIB_DEBUG
> -static int debug = 1;
> -#else
> +
> static int debug;
> -#endif
> module_param(debug, int, 0644);
>
Put this in patch #2 instead.
regards,
dan carpenter
next prev parent reply other threads:[~2024-11-04 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 21:26 [PATCH v2 00/11] staging: gpib: Patch set for gpib staging drivers Dave Penkler
2024-11-03 21:26 ` [PATCH 01/11] staging: gpib: Fix buffer overflow in ni_usb_init Dave Penkler
2024-11-03 21:26 ` [PATCH 02/11] staging: gpib: Replace custom debug with dev_dbg Dave Penkler
2024-11-03 21:26 ` [PATCH 03/11] staging: gpib: Update messaging and usb_device refs in ni_usb Dave Penkler
2024-11-03 21:26 ` [PATCH 04/11] staging: gpib: Update messaging and usb_device refs in agilent_usb Dave Penkler
2024-11-04 8:42 ` Dan Carpenter
2024-11-03 21:26 ` [PATCH 05/11] staging: gpib: Remove GPIB_DEBUG reference and update messaging Dave Penkler
2024-11-04 8:43 ` Dan Carpenter [this message]
2024-11-03 21:26 ` [PATCH 06/11] staging: gpib: Use dev_xxx for messaging Dave Penkler
2024-11-03 21:26 ` [PATCH 07/11] staging: gpib: Fix Kconfig Dave Penkler
2024-11-03 21:26 ` [PATCH 08/11] staging: gpib: Remove unneeded lookup table Dave Penkler
2024-11-03 21:26 ` [PATCH 09/11] staging: gpib: Remove GPIO14 and GPIO15 lines in lookup tables Dave Penkler
2024-11-03 21:26 ` [PATCH 10/11] staging: gpib: Re-order the " Dave Penkler
2024-11-04 8:36 ` Dan Carpenter
2024-11-03 21:26 ` [PATCH 11/11] staging: gpib: Correct check for max secondary address Dave Penkler
2024-11-04 8:09 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c4aba7e-c873-4a93-9311-bd2e2bbcd8e8@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arnd@arndb.de \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox