From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Ganesh Kumar Pittala <ganeshkpittala@gmail.com>,
Alex Elder <elder@riscstar.com>
Cc: <johan@kernel.org>, <elder@kernel.org>,
<hvaibhav.linux@gmail.com>, <pure.logic@nexus-software.ie>,
<greybus-dev@lists.linaro.org>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [greybus-dev] Re: [PATCH] staging: greybus: Multiple cleanups and refactors
Date: Mon, 31 Mar 2025 17:17:20 -0700 [thread overview]
Message-ID: <4f47df18-e98c-4f23-afde-3fa8e9fd0f86@quicinc.com> (raw)
In-Reply-To: <CALVXb-qDioGFAfmtJPu_jVR_5G7VfC2bDD_bvjicbrVZKkc=hA@mail.gmail.com>
On 3/31/2025 5:03 PM, Ganesh Kumar Pittala wrote:
> Hi Alex,
>
> Thank you for the detailed feedback and guidance. I appreciate your time
> reviewing the patch.
>
> I’ll split the changes into separate patches as suggested and send a v2 shortly.
>
> Best regards,
> Ganesh Pittala
Some more feedback:
Don't "top post"
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
Also don't use HTML e-mail
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
Yes, there are a lot of hoops you have to jump through to get your code in the
kernel. It becomes easier over time.
/jeff
next prev parent reply other threads:[~2025-04-01 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 21:33 [PATCH] staging: greybus: Multiple cleanups and refactors gpittala
2025-03-31 23:49 ` Alex Elder
[not found] ` <CALVXb-qDioGFAfmtJPu_jVR_5G7VfC2bDD_bvjicbrVZKkc=hA@mail.gmail.com>
2025-04-01 0:17 ` Jeff Johnson [this message]
2025-04-01 0:12 ` [greybus-dev] " Jeff Johnson
2025-04-01 0:52 ` kernel test robot
2025-04-01 5:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f47df18-e98c-4f23-afde-3fa8e9fd0f86@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=elder@kernel.org \
--cc=elder@riscstar.com \
--cc=ganeshkpittala@gmail.com \
--cc=greybus-dev@lists.linaro.org \
--cc=hvaibhav.linux@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox