From: Luka Gejak <luka.gejak@linux.dev>
To: nikolayof23@gmail.com
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
luka.gejak@linux.dev
Subject: Re: [PATCH v2 2/2] staging: rtl8723bs: rename DisableInterrupt8723BSdio() to snake_case
Date: Thu, 30 Apr 2026 22:43:57 +0200 [thread overview]
Message-ID: <523262EE-C246-4820-A980-E0FAA84BF977@linux.dev> (raw)
In-Reply-To: <20260430172954.12828-3-nikolayof23@gmail.com>
> Rename function DisableInterrupt8723BSdio() to
> rtw_sdio_disable_interrupt() and format its description to comply with
> Linux kernel coding style.
> Declare this function without 'extern' prototype in the .h file to fix
> checkpatch.pl warning.
>
> Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
> ---
> Changes in v2:
> - rebase on staging-next
>
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 17 +++++++----------
> drivers/staging/rtl8723bs/include/sdio_ops.h | 2 +-
> drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +-
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++--
> 4 files changed, 11 insertions(+), 14 deletions(-)
>
As far as I see in v1, Greg doesn't mind this patch doing multiple
things at once, therefore:
LGTM,
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-04-30 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 17:29 [PATCH v2 0/2] staging: rtl8723bs: cleanup hal/hal_intf.c Nikolay Kulikov
2026-04-30 17:29 ` [PATCH v2 1/2] staging: rtl8723bs: remove wrapper rtw_hal_disable_interrupt() Nikolay Kulikov
2026-04-30 20:39 ` Luka Gejak
2026-04-30 17:29 ` [PATCH v2 2/2] staging: rtl8723bs: rename DisableInterrupt8723BSdio() to snake_case Nikolay Kulikov
2026-04-30 20:43 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523262EE-C246-4820-A980-E0FAA84BF977@linux.dev \
--to=luka.gejak@linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=nikolayof23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox