Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

Heiko Stuebner
2023-08-09T12:30:24Z

Am Freitag, 4. August 2023, 16:27:06 CEST schrieb Uwe Kleine-König:
> Instead of requiring each driver to care for assigning the owner member
> of struct pwm_ops, handle that implicitly using a macro. Note that the
> owner member has to be moved to struct pwm_chip, as the ops structure
> usually lives in read-only memory and so cannot be modified.
>
> The upside is that new lowlevel drivers cannot forget the assignment and
> save one line each. The pwm-crc driver didn't assign .owner, that's not
> a problem in practise though as the driver cannot be compiled as a
> module.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---

> drivers/pwm/pwm-rockchip.c | 1 -

Acked-by: Heiko Stuebner <heiko@sntech.de> #pwm-rockchip