Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

Florian Fainelli
2023-08-04T18:56:58Z

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On 8/4/23 07:27, Uwe Kleine-König wrote:
> Instead of requiring each driver to care for assigning the owner member
> of struct pwm_ops, handle that implicitly using a macro. Note that the
> owner member has to be moved to struct pwm_chip, as the ops structure
> usually lives in read-only memory and so cannot be modified.
>
> The upside is that new lowlevel drivers cannot forget the assignment and
> save one line each. The pwm-crc driver didn't assign .owner, that's not
> a problem in practise though as the driver cannot be compiled as a
> module.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > ---

> drivers/pwm/pwm-bcm-iproc.c | 1 -
> drivers/pwm/pwm-bcm-kona.c | 1 -
> drivers/pwm/pwm-bcm2835.c | 1 -
> drivers/pwm/pwm-brcmstb.c | 1 -

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> #
pwm-{bcm,brcm}*.c
--
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]