Re: [PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

Andy Shevchenko
2023-08-04T18:52:28Z

On Fri, Aug 4, 2023 at 5:28 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Instead of requiring each driver to care for assigning the owner member
> of struct pwm_ops, handle that implicitly using a macro. Note that the
> owner member has to be moved to struct pwm_chip, as the ops structure
> usually lives in read-only memory and so cannot be modified.
>
> The upside is that new lowlevel drivers cannot forget the assignment and

low level

> save one line each. The pwm-crc driver didn't assign .owner, that's not
> a problem in practise though as the driver cannot be compiled as a
> module.

...

> drivers/pwm/pwm-lpss.c | 1 -

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> # Intel LPSS

--
With Best Regards,
Andy Shevchenko