From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96EC130E39 for ; Mon, 26 Feb 2024 16:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708966649; cv=none; b=r88vH1FLKpxJCbXBZ5eotcZhX+lre8YhfpWQoOsLVNsie5/6M7JYkJMP/d+tggZj2pXt+7a4FkLi9jXjRjZjDbJKjsPlsI+4shuN/EV0bNnIf2Y1tTp7THhVpfjqwPijVTwa9IxiyX4yYWCmf80uCHOS9mTo7IBxIRAIvrLBMVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708966649; c=relaxed/simple; bh=aJ68smvdUhAemksJrXi/fVDE0y74bVnXu1fKZwDgaUY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pp04KJJXUMIEY1f2ss0vEsHZj/xq5XmdtCXPgVzvB34+v6sihsddwJnBcf5HVkIjV6U11Q8EpBkmKaHXuPOBJj5IDU1RTC3MldWkuxH1hAFtnMQYeUK7Ulv+gSejwlQdb9oE/GefELKi2g9RTHEpKZMUjajHYQvs3CIGhBmkUiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OJVWrtqP; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OJVWrtqP" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-33d855caf7dso682537f8f.0 for ; Mon, 26 Feb 2024 08:57:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708966646; x=1709571446; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7FUUzYRpWlE/uC7gYsXYypoQ8pTl8AZIEHC0lk+2G0w=; b=OJVWrtqP6jHQAa9XoaIdVtOkWNNbBjmLjcNh1LoX3LK9LN4aj4dEXqiwoNxR4xcN3y 7BTz6gG7Prppk1FSeTXs0WBTw8+ejqA8wUZ2rVMTGsV5tAzpEnHLicQGyTFcYzQP8AVP GLqW1F8bPRTPHP6mbbMN6joxd9/vhEacF+RUJIKMoiMikZyGjzqzaGc5xb2M79acOtyM IbOXIjeh6gLpxK8xVbkX2VxcVOlqyYLLkMgTfjmnjVw86RMAhFPrxpiL3pka6Jst6SCU zhS1ol69iM95lzV1D3JhmTakRWUyqQa/ac4wP+MB83fRKc/oJFXvBuDx4SjIPT1nrDY3 8BJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708966646; x=1709571446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7FUUzYRpWlE/uC7gYsXYypoQ8pTl8AZIEHC0lk+2G0w=; b=R5IeJkJAbcyinK/J2Nosbd3TAR6sJ26Bn3RWOCZUam5F9wrUcK0qpADiZcOOEgvmIB w0ReHBWD1RvaEXc0Wgcc17PziAjTtmShwRscP0Bt6XO+N/fM97OfYMAXCCrbjCjMbNzC PGRr79wRLTzGKlQTFVU9iY5p8jGCaNy4eoC490GsvS4NbFc4oSRw4/xc1tlZV1h4l8Bq aqrwhNCvEqmsavw42tUPMB/ZW5/Fry2WrBOIJ6XpcOb7lbrWQ0BRITsfpHrFCL1ZkeqM w863rZCzxl0Cu3TP1kqdVZTo99DpV8A7Bx1K+Audnl5ZvVnI3cUTVAOY6YfGj0O12Py/ BrqA== X-Gm-Message-State: AOJu0Yw1DOeUYPyYBuK1zeT5r8NWPdartLU6Fw4WNf57eKLmPLo/jXu5 7GB0tyk8fmZsnJEuGcGK9QDGMrSH7oOIu53dkFe3PR0RV6K+cGt3 X-Google-Smtp-Source: AGHT+IHLw90iyN14oEJc7WiZp425r/pRSyRV7jZAGjdsZqUITNpewOwpnkk20eDcibcyiSXPu5kXBw== X-Received: by 2002:a5d:5a1b:0:b0:33d:297c:911c with SMTP id bq27-20020a5d5a1b000000b0033d297c911cmr6296712wrb.0.1708966645888; Mon, 26 Feb 2024 08:57:25 -0800 (PST) Received: from [192.168.0.104] (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id m26-20020a05600c3b1a00b00412a5cb5a76sm3097244wms.23.2024.02.26.08.57.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 08:57:25 -0800 (PST) Message-ID: <535eb04e-19bb-4d64-9818-7fc28195b9b1@gmail.com> Date: Mon, 26 Feb 2024 17:57:24 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] Staging: rtl8192e: Rename function rtllib_FlushRxTsPendingPkts() To: Tree Davies , gregkh@linuxfoundation.org, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240226035915.370478-1-tdavies@darkphysics.net> <20240226035915.370478-8-tdavies@darkphysics.net> Content-Language: en-US From: Philipp Hortmann In-Reply-To: <20240226035915.370478-8-tdavies@darkphysics.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/26/24 04:59, Tree Davies wrote: > Rename function rtllib_FlushRxTsPendingPkts -> rtllib_flush_rx_ts_pending_pkts This line is too long. WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) # > to fix checkpatch warning Avoid CamelCase. > > Signed-off-by: Tree Davies > --- > drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- > drivers/staging/rtl8192e/rtllib.h | 2 +- > drivers/staging/rtl8192e/rtllib_rx.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c > index 0581ed1e9ed1..04f3fb54d1b7 100644 > --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c > +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c > @@ -268,7 +268,7 @@ int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb) > goto on_add_ba_req_fail; > } > > - rtllib_FlushRxTsPendingPkts(ieee, ts); > + rtllib_flush_rx_ts_pending_pkts(ieee, ts); > > deactivate_ba_entry(ieee, ba); > ba->dialog_token = *dialog_token; > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > index 05abc001507c..fe850dbeaa02 100644 > --- a/drivers/staging/rtl8192e/rtllib.h > +++ b/drivers/staging/rtl8192e/rtllib.h > @@ -1810,7 +1810,7 @@ bool rtllib_mgnt_disconnect(struct rtllib_device *rtllib, u8 rsn); > /* For the function is more related to hardware setting, it's better to use the > * ieee handler to refer to it. > */ > -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee, > +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee, > struct rx_ts_record *ts); CHECK: Alignment should match open parenthesis #40: FILE: drivers/staging/rtl8192e/rtllib.h:1814: +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee, struct rx_ts_record *ts); > int rtllib_parse_info_param(struct rtllib_device *ieee, > struct rtllib_info_element *info_element, > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c > index 051371e0138c..be0f92e97d12 100644 > --- a/drivers/staging/rtl8192e/rtllib_rx.c > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > @@ -487,7 +487,7 @@ void rtllib_indicate_packets(struct rtllib_device *ieee, > } > } > > -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee, > +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee, > struct rx_ts_record *ts) CHECK: Alignment should match open parenthesis #40: FILE: drivers/staging/rtl8192e/rtllib.h:1814: +void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee, struct rx_ts_record *ts); > { > struct rx_reorder_entry *pRxReorderEntry;